Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add essence variants #48

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Add essence variants #48

merged 3 commits into from
Nov 8, 2019

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 7, 2019

Add a new essence EssenceSpreeVariant that allows to pick a variant

BenAkroyd
BenAkroyd approved these changes Nov 7, 2019
View reviewed changes
Copy link

@BenAkroyd BenAkroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!

mamhoff
mamhoff approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true:

v  = FactoryBot.build(:variant)
v == Spree::Variant.new(id: v.id)

app/models/alchemy/essence_spree_variant.rb Show resolved Hide resolved
@tvdeyen tvdeyen merged commit b4b936f into master Nov 8, 2019
@tvdeyen tvdeyen deleted the add-essence-variants branch November 8, 2019 16:53
tvdeyen added a commit that referenced this pull request Nov 12, 2019
@tvdeyen
v2.5.0
17077cc 
- Use Select2 ajax for Taxon select [\#52](#52) ([tvdeyen](https://github.com/tvdeyen))
- Add support for Ransack query params [\#51](#51) ([tvdeyen](https://github.com/tvdeyen))
- Use Select2 Ajax feature for Essence Product [\#50](#50) ([tvdeyen](https://github.com/tvdeyen))
- Use Select2 for variant search [\#49](#49) ([tvdeyen](https://github.com/tvdeyen))
- Add essence variants [\#48](#48) ([tvdeyen](https://github.com/tvdeyen))
- CI build fixes [\#47](#47) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenAkroyd BenAkroyd BenAkroyd approved these changes

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @mamhoff @BenAkroyd