Use Select2 for variant search #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting an invalid Spree::Variant instance we just the variant_id if an ID is passed instead of a Variant to the ingredient setter method.
Loading all variants in each essence editor editor partial is a huge performance issue. Use select2 ajax feature, so that the variants get loaded on demand.
We now have javascript assets (the ajax based variant select) that needs to be installed in the host app.
tvdeyen
added a commit
that referenced
this pull request
Nov 12, 2019
- Use Select2 ajax for Taxon select [\#52](#52) ([tvdeyen](https://github.com/tvdeyen)) - Add support for Ransack query params [\#51](#51) ([tvdeyen](https://github.com/tvdeyen)) - Use Select2 Ajax feature for Essence Product [\#50](#50) ([tvdeyen](https://github.com/tvdeyen)) - Use Select2 for variant search [\#49](#49) ([tvdeyen](https://github.com/tvdeyen)) - Add essence variants [\#48](#48) ([tvdeyen](https://github.com/tvdeyen)) - CI build fixes [\#47](#47) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of preloading all variants - what can be a lot in some stores - we make use of the Ajax loading feature of select2 in the variant select box of the newly introduced essence_spree_variant.
Also includes fixes for the ingredient setter method and the preview text.