Merge pull request #2896 from tvdeyen/harden-specs

Harden specs

spec/features/admin/ingredient_pictures_feature_spec.rb

@@ -14,7 +14,9 @@
   end
 
   scenario "Picture description is used as default for ingredient picture alt text" do
-    visit alchemy.edit_admin_ingredient_path(ingredient_picture)
-    expect(page).to have_field("Alternative text", placeholder: "A nice picture")
+    Alchemy::Deprecation.silence do
+      visit alchemy.edit_admin_ingredient_path(ingredient_picture)
+      expect(page).to have_field("Alternative text", placeholder: "A nice picture")
+    end
   end
 end

spec/features/admin/nodes_management_spec.rb

@@ -29,7 +29,7 @@ def add_menu_item
     add_menu_item
 
     within "#page_nodes table" do
-      expect(page).to have_content("Menu node MenuA Page 1")
+      expect(page).to have_content("Menu node Menu#{a_page.name}")
     end
     within "[panel='nodes']" do
       expect(page).to have_content("(1) Menu node")
@@ -59,7 +59,7 @@ def add_menu_item
       end
 
       within "#page_nodes table" do
-        expect(page).to_not have_content("Menu node MenuA Page 1")
+        expect(page).to_not have_content("Menu node Menu#{a_page.name}")
         expect(page).to have_content(Alchemy.t("No menu node for this page found"))
       end
       within "[panel='nodes']" do

spec/views/alchemy/admin/ingredients/edit_spec.rb

@@ -8,6 +8,12 @@
     view.instance_variable_set(:@ingredient, ingredient)
   end
 
+  around do |example|
+    Alchemy::Deprecation.silence do
+      example.run
+    end
+  end
+
   context "for a picture ingredient" do
     let(:image) do
       fixture_file_upload(