Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden specs #2896

Merged
merged 2 commits into from
May 27, 2024
Merged

Harden specs #2896

merged 2 commits into from
May 27, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 27, 2024

See commits

tvdeyen added 2 commits May 27, 2024 11:06
We deprecated float positioning in picture and file ingredients
The name is dependent from the database id.
@tvdeyen tvdeyen requested a review from a team as a code owner May 27, 2024 09:06
@tvdeyen tvdeyen enabled auto-merge May 27, 2024 09:06
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (682f201) to head (2fad69d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2896   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         230      230           
  Lines        6269     6269           
=======================================
  Hits         6016     6016           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 4bf0fa9 into AlchemyCMS:main May 27, 2024
35 checks passed
@tvdeyen tvdeyen deleted the harden-specs branch May 27, 2024 09:12
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than soft coding the name of the page, can we give the page a name in the test setup and test for that?

let(:page) { create(:alchemy_page, name: "Strawberry Fields") }

...

expect(node.url).to eq("my_node/strawberry_fields")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants