Do not prevent default click handling in Element editor #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
requested changes
May 17, 2018
| # Element submit button needs to keep it's default event | ||
| e.preventDefault() unless $target.is(':submit') | ||
| # Buttons, inputs and labels need to handle their clicks. | ||
| e.preventDefault() unless $target.is(':submit, input, label') |
There was a problem hiding this comment.
Just tested it. It even works with e.preventDefault completely removed.
Check boxes, their labels, and submit buttons need to handle their own click events.
mamhoff
force-pushed
the
quick-checkbox-fix
branch
from
5d98ced to
8447e4f
Compare
|
Ha! Fixed a frontend bug! Thanks for the review, I deleted the two lines. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check boxes, their labels, and submit buttons need to handle their own click
events.
What is this pull request for?
Closes #1444
Notable changes (remove if none)
I'm not very sure about this change as I don't quite get why the
preventDefaultcall is in that method at all. With this change, clicks will actually click buttons, labels and inputs. That's most of the area of an Element editor.