expose translations in global Alchemy js object, #2113 #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Jun 4, 2021
This was referenced Jun 7, 2021
Merged
Merged
Merged
|
Dang this never passed Jest specs :( |
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Jun 7, 2021
They were missing from AlchemyCMS#2114
Merged
robinboening
pushed a commit
to robinboening/alchemy_cms
that referenced
this pull request
Jul 2, 2021
They were missing from AlchemyCMS#2114
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- Backport #2115 to v5.0 [#2126](#2126) ([dbwinger](https://github.com/dbwinger)) - Fixate Dragonfly to < 1.4 [#2122](#2122) ([tvdeyen](https://github.com/tvdeyen)) - Backport #2114 to v5.0 [#2118](#2118) ([afdev82](https://github.com/afdev82))
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- generate picture thumbnails only for pictures with convertible format [#2131](#2131) ([afdev82](https://github.com/afdev82)) - Backport #2115 to v5.1 [#2125](#2125) ([dbwinger](https://github.com/dbwinger)) - Backport #2114 to v5.1 [#2117](#2117) ([afdev82](https://github.com/afdev82))
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- Return only pages from current site in api [#2169](#2169) ([afdev82](https://github.com/afdev82)) - Improve cache key defaults for menus #2138 [#2160](#2160) ([oneiros](https://github.com/oneiros)) - generate picture thumbnails only for pictures with convertible format [#2130](#2130) ([afdev82](https://github.com/afdev82)) - Backport #2114 to v5.2 [#2116](#2116) ([afdev82](https://github.com/afdev82)) - Add webpacker tasks to Alchemy upgrader [#2115](#2115) ([dbwinger](https://github.com/dbwinger))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Closes #2113 and it's a prerequisite for AlchemyCMS/alchemy_i18n#34
It needs to be backported to all v5.x versions of Alchemy, because since Webpacker was added, the gem is broken.
Notable changes (remove if none)
The global JS object Alchemy now contains the key
translationslike in Alchemy v4, in order to use it to add other translations using the alchemy_i18n gem.Checklist