Add webpacker tasks to Alchemy upgrader #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni...
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml
|
I was planning to work on that too, thank you for opening this! |
|
I see a bunch of spec are failing with |
|
Unfortunately GitHub mobile does not show me which branch this is targeted. Assuming it's a 5.x branch it will most likely be due to the breaking 1.4 release of dragonfly. Pinning the version to < 1.4 should fix the builds. |
dbwinger
force-pushed
the
upgrader-webpacker
branch
from
1cf221c to
ad55c20
Compare
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecogni...
Error: unrecognized cop Lint/DuplicateBranch found in .rubocop.yml, unrecognized cop Lint/DuplicateRegexpCharacterClassElement found in .rubocop.yml, unrecognized cop Lint/EmptyBlock found in .rubocop.yml, unrecognized cop Lint/EmptyClass found in .rubocop.yml, unrecognized cop Lint/NoReturnInBeginEndBlocks found in .rubocop.yml, unrecognized cop Lint/ToEnumArguments found in .rubocop.yml, unrecognized cop Lint/UnexpectedBlockArity found in .rubocop.yml, unrecognized cop Lint/UnmodifiedReduceAccumulator found in .rubocop.yml, unrecognized cop Style/ArgumentsForwarding found in .rubocop.yml, unrecognized cop Style/CollectionCompact found in .rubocop.yml, unrecognized cop Style/DocumentDynamicEvalDefinition found in .rubocop.yml, unrecognized cop Style/NegatedIfElseCondition found in .rubocop.yml, unrecognized cop Style/NilLambda found in .rubocop.yml, unrecognized cop Style/RedundantArgument found in .rubocop.yml, unrecognized cop Style/SwapValues found in .rubocop.yml
|
Thanks @tvdeyen . Yes, that was it. And yes, this PR is against 5.2-stable and should be backported to 5.1 and 5.0 since it affects the 5.0 upgrader. |
|
@dbwinger thanks. |
|
Thank you @tvdeyen. Will you take care of getting this into 5.0 and 5.1 or should I open PRs for those branches as well? |
|
@dbwinger any help is appreciated. |
dbwinger
added a commit
to dbwinger/alchemy_cms
that referenced
this pull request
Jun 9, 2021
Merged
dbwinger
added a commit
to dbwinger/alchemy_cms
that referenced
this pull request
Jun 9, 2021
Merged
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- Backport #2115 to v5.0 [#2126](#2126) ([dbwinger](https://github.com/dbwinger)) - Fixate Dragonfly to < 1.4 [#2122](#2122) ([tvdeyen](https://github.com/tvdeyen)) - Backport #2114 to v5.0 [#2118](#2118) ([afdev82](https://github.com/afdev82))
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- generate picture thumbnails only for pictures with convertible format [#2131](#2131) ([afdev82](https://github.com/afdev82)) - Backport #2115 to v5.1 [#2125](#2125) ([dbwinger](https://github.com/dbwinger)) - Backport #2114 to v5.1 [#2117](#2117) ([afdev82](https://github.com/afdev82))
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- Return only pages from current site in api [#2169](#2169) ([afdev82](https://github.com/afdev82)) - Improve cache key defaults for menus #2138 [#2160](#2160) ([oneiros](https://github.com/oneiros)) - generate picture thumbnails only for pictures with convertible format [#2130](#2130) ([afdev82](https://github.com/afdev82)) - Backport #2114 to v5.2 [#2116](#2116) ([afdev82](https://github.com/afdev82)) - Add webpacker tasks to Alchemy upgrader [#2115](#2115) ([dbwinger](https://github.com/dbwinger))
gr8bit
added a commit
to bichinger/alchemy_cms
that referenced
this pull request
Apr 12, 2022
…ctive-storage-integration * '5.0-stable' of github.com:AlchemyCMS/alchemy_cms: (34 commits) Bump version to v5.0.10 Add crop_resize Dragonfly processor make the admin error tracker customizable Bump npm package Bump version to v5.0.9 Adjust tinymce skin assets urls again Bump npm package version to v5.0.8 Bump version to v5.0.8 Set stampable user_class_name without root identifier Use relative path for tinymce font-face Bump version to v5.0.7 Make sure to install correct npm package Bump version to v5.0.6 Use self_and_ancestors in page_active? helper Bump version to v5.0.5 Bump NPM package version to 5.0.4 Backport AlchemyCMS#2115 to v5.0 Fixes i18n Jest specs expose translations in global Alchemy js object, AlchemyCMS#2113 Fixate Dragonfly to < 1.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds Alchemy 5 upgrade tasks to complete required wepbacker setup, mirroring installer tasks, run webpacker installer, add alchemy's npm package, and copy alchemy's webpack entry point.
Closes #1937
Checklist
(I don't see any existing tests for the upgrader tasks, unless I'm missing them)