Allow all pages in API again #2258
Conversation
This reverts the changes made in 59467e8 and 5c3f912 We need to be able to list all pages from the admin API, because admin users need to be able to link pages from other sites and languages. Since we do not have a way right now to restrict pages, languages and sites to certain admin users we need to return all. Pending is a change to the page select UI that shows the site/domain and language a page is, so that admin users can distinguish pages visually.
|
@dbwinger does this look good to you? |
We want to display the site in the page select.
We want admins to be able to distinguish the page by site and language.
tvdeyen
force-pushed
the
allow-all-pages-in-api-again
branch
from
294ba32 to
a544ad1
Compare
Good point and yes this looks good to me. Would you want to include something similar for the |
@dbwinger can you elaborate what the use case for the node select is? I can barely image a menu node to be referenced on another language or site? |
Backport pull request #2258 from tvdeyen/allow-all-pages-in-api-again
Actually you're right. I don't need to reference a node on another language/site but currently the node selector is searching ALL nodes (no matter the language/site) and doesn't show the language/site so it's not discernable. So either confining results to the current site/language or displaying the site/language would suffice. For what it's worth, here's my use case. I built a "mega-menu" global page, with an element corresponding to the mega-menu that should show for each menu item. I associate the element with a |
We were missing a third argument in order to be able to use this permission with the `.accessible_by` scope.
We were missing a third argument in order to be able to use this permission with the `.accessible_by` scope.
… Pages API requests for page select on link overlay" We need to revert the change made in AlchemyCMS#2439. We return all pages from the API on purpose. As already discussed in AlchemyCMS#2258 The actual issue was introduced in c98605a where we started to scope the pages to the language again. This change needs to be reverted as well. This reverts commit f695769.
What is this pull request for?
This reverts the changes made in 59467e8 and 5c3f912
We need to be able to list all pages from the admin API, because admin users need to be able to link pages from other sites and languages. Since we do not have a way right now to restrict pages, languages and sites to certain admin users we need to return all.
References #2207
Notable changes
Change the admin page select UI so that it shows the site/domain and language a page is on, so that admin users can distinguish pages visually.
Screenshots
Checklist