Send language_id (of the currently editing page) parameter to Pages API requests for page select on link overlay #2439
Conversation
dbwinger
force-pushed
the
link-dialog-lang
branch
from
4f4f6b7 to
8aef75a
Compare
We were missing a third argument in order to be able to use this permission with the `.accessible_by` scope.
|
This pull request has not seen any activiy in a long time. |
|
@dbwinger sorry, this totally slipped out of my radar. Could you please rebase this with latest main branch? Thanks |
dbwinger
force-pushed
the
link-dialog-lang
branch
from
8aef75a to
314d74e
Compare
|
@dbwinger thanks. The spec error seems to be related. Mind taking another look? |
|
@tvdeyen Yeah, I'll get it fixed tomorrow. |
…PI requests for page select on link overlay
dbwinger
force-pushed
the
link-dialog-lang
branch
from
a79e926 to
f695769
Compare
Should be ready to go now. |
|
This broke the page link in TinyMCE editor instances. |
Ok, I'll take a look ASAP. |
|
That one is a bit tricky, because we do not have access to the DOM element
I think the best bet is to globally store the current page language on the global Alchemy JS object.
|
|
Ok. Would it be helpful for me to submit a PR or is it easier for you to handle it? If you'd like me to, are you thinking it would be best done inside the existing script tag of |
|
I can handle it. Already started looking into it anyway 😉 |
|
Great thanks!
…On Wed, Jun 28, 2023 at 3:48 PM Thomas von Deyen ***@***.***> wrote:
I can handle it. Already started looking into it anyway 😉
—
Reply to this email directly, view it on GitHub
<#2439 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACTAF3LT3S4B2PJ5BFTFZLXNSDA5ANCNFSM6AAAAAAWBIM7FA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
… Pages API requests for page select on link overlay" We need to revert the change made in AlchemyCMS#2439. We return all pages from the API on purpose. As already discussed in AlchemyCMS#2258 The actual issue was introduced in c98605a where we started to scope the pages to the language again. This change needs to be reverted as well. This reverts commit f695769.
What is this pull request for?
Describe you pull request here...
API::PagesController#indexdefaults to filtering to Pages fromAlchemy::Language.currentiflanguage_idis not given. Thelanguage_idof the page being edited should be given.Checklist