Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to comp residuals and estimate ep durarion #11

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

eduardocorrearaujo
Copy link
Collaborator

Changes to solve issue #9.

Please review the new function comp_duration to see if it can be optimized.

Also, now, to run the class it is necessary to provide the muninames as a dict, so it's necessary to have the 'muni_br.gpkg' where the code is running, I did not find this folder.

@fccoelho fccoelho requested a review from esloch November 20, 2023 21:54
@fccoelho
Copy link
Contributor

@esloch could you have a look as well please?

@esloch
Copy link
Collaborator

esloch commented Nov 21, 2023

Also, now, to run the class it is necessary to provide the muninames as a dict, so it's necessary to have the 'muni_br.gpkg' where the code is running, I did not find this folder.

Hi @eduardocorrearaujo. You can locate the file in the following directory:
https://github.com/AlertaDengue/episcanner-downloader/blob/main/epi_scanner/data/muni_br.gpkg

Please review the new function comp_duration to see if it can be optimized.

Suggestion:
It would be beneficial to write small unit tests to validate the implementations.


Please, remember to add the package to pyproject.toml using poetry add epiweek.

I have your working branch; I'll also be validating the function once you add the dictionary so I can check the data generation.

@fccoelho fccoelho merged commit 380272a into AlertaDengue:main Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants