Add Flight api skeleton #85
Conversation
AlexanderOtavka
temporarily deployed
to
ride-board-flight-api-umvllcak
There was a problem hiding this comment.
This looks like a reasonable interface to me, but maybe we could combine these methods into one flight search method, where you can optionally specify
- Airline
- Airport
- Flight number
- Date
and it would give you a list of matching flights that we could show to the user and let them pick.
app/services/flights/service.rb
Outdated
| # Caller note: there do not appear to be guarantees that there will only be one | ||
| # flight for a given flight number, so we should be prepared to handle the case | ||
| # where we get multiple back |
There was a problem hiding this comment.
Multiple results is fine. I would imagine entering a date and flight number as more of a search operation, and then we let the user pick out their flight from a list (possibly with length 1 for an exact match or 0 for not found)
app/services/flights/service.rb
Outdated
| # Possible results: ApiError, [Flight] | ||
| # | ||
| # Uses same api endpoint as find_flight_by_number | ||
| def find_flight_by_airport |
There was a problem hiding this comment.
What are the parameters here? Airport + airline + date?
app/services/flights/service.rb
Outdated
| # and hopefully a flightaware faFlightID we can use to keep track of the flight | ||
| # in the future | ||
| # | ||
| # Possible results: ApiError, FlightNotFound, NonEmpty [Flight] |
There was a problem hiding this comment.
Why are "FlightNotFound, NonEmpty [Flight]" separate options? "FlightNotFound" is just the bottom case of a list.
AlexanderOtavka
temporarily deployed
to
ride-board-flight-api-irrqcjab
AlexanderOtavka
had a problem deploying
to
ride-board-flight-api-irrqcjab
AlexanderOtavka
had a problem deploying
to
ride-board-flight-api-irrqcjab
AlexanderOtavka
had a problem deploying
to
ride-board-flight-api-irrqcjab
|
@AlexanderOtavka the environment variables in heroku will need to be updated for this to work |
AlexanderOtavka
had a problem deploying
to
ride-board-flight-api-irrqcjab
AlexanderOtavka
had a problem deploying
to
ride-board-flight-api-irrqcjab
AlexanderOtavka
temporarily deployed
to
ride-board-flight-api-irrqcjab
|
Just added the environment variables to this review app. This is just a reminder for myself: DON'T FORGET TO ADD THE KEYS TO THE WHOLE PIPELINE |
AlexanderOtavka
temporarily deployed
to
ride-board-flight-api-irrqcjab
Provides a start on #27 (and to some extent #28). I'm mostly looking for feedback here on potential additional information that would be needed for an MVP, or if there is preference for a different interface in the code.