Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] BytesIter should be an unsafe trait or private #104

Closed
Manishearth opened this issue Jul 25, 2023 · 1 comment · Fixed by #115
Closed

[BUG] BytesIter should be an unsafe trait or private #104

Manishearth opened this issue Jul 25, 2023 · 1 comment · Fixed by #115
Assignees
@Alexhuszagh
Labels
A-sec Issues with potential security implications. bug Something isn't working
Milestone
1.0

Comments

@Manishearth
Copy link
Contributor

BytesIter seems to have a safety invariant:

https://github.com/Alexhuszagh/rust-lexical/blob/09c686b075096d48155cfb32265068f962afc56c/lexical-util/src/iterator.rs#L20-L22C1

This means the trait should be private or unsafe. I don't have time to craft a testcase, but it would mostly be an implementation of BytesIter that does these incorrectly and gets used elsewhere.
@Manishearth Manishearth added the bug Something isn't working label Jul 25, 2023
@Manishearth Manishearth mentioned this issue Aug 3, 2023
Closed
@eric-seppanen eric-seppanen mentioned this issue Dec 29, 2023
Closed
@BatmanAoD BatmanAoD mentioned this issue Feb 5, 2024
Closed
@eric-seppanen eric-seppanen mentioned this issue Feb 23, 2024
Open
This was referenced May 23, 2024
Open
Open
Open
@Alexhuszagh
Copy link
Owner

Sounds like it should be an unsafe trait then since we use it in other workspaces.

This was referenced Sep 9, 2024
Open
Open
Alexhuszagh added a commit that referenced this issue Sep 9, 2024
@Alexhuszagh
Ensure BytesIter is an unsafe trait.
113252e 
Closes #104.

Part of fixes to addrss #100.
@Alexhuszagh Alexhuszagh mentioned this issue Sep 9, 2024
Merged
Alexhuszagh added a commit that referenced this issue Sep 9, 2024
@Alexhuszagh
Ensure BytesIter is an unsafe trait.
47fb4b8 
Closes #104

Part of fixes to address #100
Alexhuszagh added a commit that referenced this issue Sep 9, 2024
@Alexhuszagh
Ensure BytesIter is an unsafe trait.
b07e866 
Closes #104

Part of fixes to address #100
@Alexhuszagh Alexhuszagh added the A-sec Issues with potential security implications. label Sep 14, 2024
@Alexhuszagh Alexhuszagh added this to the 1.0 milestone Sep 14, 2024
@Alexhuszagh Alexhuszagh mentioned this issue Sep 15, 2024
Closed
This was referenced Sep 16, 2024
Open
Open
Closed
Open
Open
Open
Closed
@github-actions github-actions bot mentioned this issue Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexhuszagh Alexhuszagh

Labels
A-sec Issues with potential security implications. bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Ensure BytesIter is an unsafe trait. Alexhuszagh/rust-lexical
2 participants
@Manishearth @Alexhuszagh