Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all warnings and update dependencies #56

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

Gelbpunkt
Copy link
Contributor

I ran cargo test and cargo bench to check that everything still compiles, which it does. However I'm not sure especially regarding the rand dependency.

This fixes #55 by using <Limb as Integer>::BITS to avoid conflicts with the latest nightly and also fixes all other warnings due to unused documentation by moving them inside the macro.

@Gelbpunkt
Copy link
Contributor Author

Downgraded rand again to match rustc's tests, I didn't see that it was copied from there. Also ran cargo tests in all directories where I could find any and fixed issues with proptest 0.10 changes. There's one test failure in f32_quickcheck but that seems unrelated to the changeset here.

@myrrlyn myrrlyn merged commit 1807632 into Alexhuszagh:master Feb 13, 2021
@myrrlyn
Copy link
Collaborator

myrrlyn commented Feb 13, 2021

Hi! Thank you for this PR. I'm now helping to maintain the crate until the original author is able to resume work.

I appreciate your care with keeping fidelity to the original state of the crate. I've merged this and published to crates.io as 0.7.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compilation Fails on Latest Nightly
2 participants