Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Compilation Fails on Latest Nightly #55

Closed
HTGAzureX1212 opened this issue Feb 2, 2021 · 5 comments · Fixed by #56
Closed

[BUG] Compilation Fails on Latest Nightly #55

HTGAzureX1212 opened this issue Feb 2, 2021 · 5 comments · Fixed by #56
Assignees
@Alexhuszagh
Labels
bug Something isn't working

Comments

@HTGAzureX1212
Copy link

Description

When building the crate with the latest nightly, the compilation fails with 27 errors.

Prerequisites

  • Rust version : rustc 1.51.0-nightly (d4e3570db 2021-02-01)
  • lexical version: 0.7.4

All of them are E0308 and E0277
@HTGAzureX1212 HTGAzureX1212 added the bug Something isn't working label Feb 2, 2021
@HTGAzureX1212
Copy link
Author

The compilation works on the nightly build on 2021-01-31.

@thomaseizinger
Copy link

Here is an example build: https://github.com/testcontainers/testcontainers-rs/runs/1811323780?check_suite_focus=true

@HTGAzureX1212 HTGAzureX1212 mentioned this issue Feb 2, 2021
Closed
@HTGAzureX1212
Copy link
Author

It looks like <integer>::BITS has been stabilized in the standard library, therefore that Limb::BITS resolved into a u32 instead of usize.

@wayofthepie wayofthepie mentioned this issue Feb 2, 2021
Merged
@rfk rfk mentioned this issue Feb 2, 2021
Closed
@tobz tobz mentioned this issue Feb 3, 2021
Merged
@Gelbpunkt Gelbpunkt mentioned this issue Feb 3, 2021
Merged
@Minoru Minoru mentioned this issue Feb 3, 2021
Merged
@ranile ranile mentioned this issue Feb 3, 2021
Closed
5 tasks
@astraw
Copy link

astraw commented Feb 4, 2021

Looks like rust nightly will revert the change until lexical-core can implement a suitable fix.

@rainliu
Copy link

rainliu commented Feb 5, 2021

Got the same error in https://github.com/webrtc-rs/ice/runs/1836585080

@danielzgtg danielzgtg mentioned this issue Feb 5, 2021
Open
Minoru added a commit to newsboat/newsboat that referenced this issue Feb 13, 2021
@Minoru
Bump lexical-core to 0.7.5
323b826 
This fixes the compile error that made 0.7.4 fail to build with recent
Nightly compilers (in turn failing our PRs #1459 and #1461). The change
in Nightly was reverted, giving lexical-core time to get fixed
(Alexhuszagh/rust-lexical#55). Now that that's
done, we can expect the change to be re-introduced into Nightly, and so
we have to update to lexical-core 0.7.5 lest our build breaks again.
@Minoru Minoru mentioned this issue Feb 13, 2021
Merged
@oxarbitrage oxarbitrage mentioned this issue Feb 16, 2021
Merged
@JohnTitor JohnTitor mentioned this issue Apr 25, 2021
Merged
@Stargateur Stargateur mentioned this issue Apr 29, 2021
Closed
zeerooth added a commit to BrainiumLLC/cargo-mobile that referenced this issue May 20, 2021
@zeerooth
pin lexical-core version containing a nightly/beta fix; more info: Al…
3fbcd86 
…exhuszagh/rust-lexical#55
@dennisschagt dennisschagt mentioned this issue Jun 17, 2021
Closed
@legoktm legoktm mentioned this issue Jun 18, 2021
Closed
@0323pin 0323pin mentioned this issue Sep 13, 2021
Closed
dholroyd added a commit to dholroyd/strck that referenced this issue Sep 26, 2021
@dholroyd
Update lexical-core version
101db7d 
Needed to avoid Alexhuszagh/rust-lexical#55
in later Rust releases.
@craftyguy craftyguy mentioned this issue Oct 4, 2021
Closed
TonalidadeHidrica added a commit to TonalidadeHidrica/taiko-untitled that referenced this issue Oct 24, 2021
@TonalidadeHidrica
Update lexical-core from 0.7.4 to 0.7.6
a7e9b0e 
Without this, bumping Rust version to 1.52.1 would fail.
See Alexhuszagh/rust-lexical#55 for more details.
@alexanderkjall alexanderkjall mentioned this issue Nov 30, 2021
Closed
@InternetUnexplorer InternetUnexplorer mentioned this issue Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexhuszagh Alexhuszagh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all warnings and update dependencies Gelbpunkt/rust-lexical
5 participants
@astraw @rainliu @thomaseizinger @Alexhuszagh @HTGAzureX1212