Partly revert removal of docs and coverage CI #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dconnolly
reviewed
Feb 16, 2021
dconnolly
reviewed
Feb 16, 2021
oxarbitrage
force-pushed
the
issue1689
branch
from
7fea9fc
to
9323ddd
Compare
oxarbitrage
force-pushed
the
issue1689
branch
from
9323ddd
to
104d48e
Compare
teor2345
changed the title
|
This is a partial revert, because some of the reverted config has been changed to beta rust |
dconnolly
added
A-devops
dconnolly
reviewed
Feb 16, 2021
dconnolly
approved these changes
Feb 17, 2021
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Research and fix the cause of failing CI docs and coverage.
Solution
Revert #1688 fully but use
betaas the toolchain instead ofnightlyin the docs. For the coverage we need to stay in nightly as coverage uses a compiler option-Zonly available there.More info about docs failure at Alexhuszagh/rust-lexical#55
We used nightly because of some nightly-only docs feature that are available in beta now.
Review
@dconnolly after CI pass.
Related Issues
Close #1689 and close #1690