Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support member/gollum/fork events #72

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

wayofthepie
Copy link
Contributor

These are also small. MemberEvent in reality has some slight differences from the docs (see github/docs#3378). Thanks!

@wayofthepie
Copy link
Contributor Author

Ah just noticed it's failing on nightly. Alexhuszagh/rust-lexical#55 seems to be the cause.

@wayofthepie
Copy link
Contributor Author

Oh, this PR slipped my mind, this is good now. You're probably aware, but the issue was nightly introduced a change that broke lexical (this broke octocrab in general, deps were wiremock -> nom -> lexical), nightly reverted it, and a few days ago lexical got a new release which fixes the issue.

No rush with reviewing or anything, just commenting in case you wanted me to clarify the above!

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit d3beecd into XAMPPRocky:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants