Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2/n: Update wilms 06 module #860

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented Nov 6, 2024

Towards #850
Part of #852

This PR begins the next stages of updates for the Wilms 06 module:

  • For Update the wilms 06 workflow script and GHA #852, I added the RUN_EXPLORATORY flag to the module's workflow, and I use it (so far!) to skip the 00b reference exploration notebook, and the 03 clustering notebook.
  • Even so, I also updated the 03 clustering notebook to be able to run in CI - for example, we might want such steps to run on pulls but not PRs? Any thoughts there?
  • I re-rendered all the sample-specific clustering notebooks, which is the MAJORITY of changes here!

Edit: Fun times with GitHub interface with this one... I could split up the notebooks into a few batches across PRs? Please let me know if that would be preferable!

@sjspielman
Copy link
Member Author

Closing in favor of opening a new smaller PR, since this one is still too big!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant