Updated wilms clustering notebooks 1/3 #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2024
jaclyn-taroni
previously approved these changes
Nov 6, 2024
Comment on lines
5
to
7
| # 1. The TESTING variable controls whether test data should be used. | ||
| # Setting TESTING=1 will use the test data. | ||
| # This variable is 0 by default. |
There was a problem hiding this comment.
This doesn't seem accurate – it controls whether or not particular steps are run. What data is being used is entirely controlled by what happens to be symlinked at data/current, or am I missing something?
There was a problem hiding this comment.
No, you're not missing something - this description needs tweaking.
sjspielman
dismissed
jaclyn-taroni’s stale review
We caught a bug in the notebook
|
Moving right along!
|
sjspielman
merged commit 6165a3f
into
AlexsLemonade:feature/wilms-tumor-06-azimuth
3 checks passed
sjspielman
deleted the
sjspielman/updated-wilms-cluster-notebooks-batch1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying again for #860!
Towards #850
Part of #852
This PR continues updates for the Wilms 06 module:
RUN_EXPLORATORYflag to the module's workflow, and I use it (so far!) to skip the 00b reference exploration notebook, and the 03 clustering notebook.