-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Swift 2.3 #184
Support Swift 2.3 #184
Conversation
Thanks for the PR ! 👍 Wondering if I should really merge the last commit of your PR 80860843e066450b95ab09bb01960e5f2949c11d (the one containing that patch described in Quick/Nimble#302) or better wait for the next Xcode beta to see if it's fixed. Keeping that patch in the long run in the repo would seem hacky to me (because let's be honest, if I merge this patch commit I'll forget about it in a few weeks/months and never remove it later 😉) |
Thanks for your thought! I'm OK to wait for the next Xcode beta to remove the workaround. In the meantime I'll using the branch personally. |
Hey @ikesyo ! It seems like the workarounds (for linker & device codesigning) are no longer needed in Xcode 8 beta 2? Quick/Nimble#316 Could you thus please remove the workaround commits from this PR so we can move forward and merge a cleaner solution then? Thx! |
Note that we might also want to tweak the You can find some inspiration on this |
0445f0d
to
66e8ead
Compare
3b925ba
to
51cef8e
Compare
…odebuild` That can't be used on Xcode 8 (`platform=macOS` should be used instead). So removes `platform=` from `-destination` option and specifies `-sdk` option instead.
Travis now supports Xcode 8 beta 2: https://twitter.com/travisci/status/752704816116293632. But the iOS tests are randomly failed as seen in the following:
|
Sadly that happens more and more on Travis lately, builds taking ages to start and builds randomly failing, while they pass perfectly locally. Not sure if I can do anything about it. I could deactivate my timing tests for all but one build, that would probably help as those expect the response to be in a specific time window to ensure the given responseTime is respected… but if the Travis VM is too solicited and slow that doesn't help. But the most build fails I've seen lately are not because of them but more because of Travis failing to launch th Xcode test command, so I'm puzzled… I just relaunched the Travis build that failed and hope it will pass this time, until I have more time to investigate that Travis bug. |
41ef12c
to
b4d2bb1
Compare
This should be compatible with both Swift 2.2/Xcode 7.3 and Swift 2.3/Xcode 8.