Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set deployment targets at the project level #185

Merged

Conversation

ikesyo
Copy link
Collaborator

@ikesyo ikesyo commented Jun 22, 2016

This simplifies the project settings a bit and is required to be used in a universal target (e.g. ishkawa/APIKit#179).

This simplifies the project settings a bit.
@ikesyo ikesyo force-pushed the project-level-deployment-target branch from bfeb420 to 8f62bc4 Compare June 22, 2016 16:09
@AliSoftware
Copy link
Owner

Great!
Thx for the PR 👍

Could you please add an entry in the CHANGELOG to credit yourself? Thx!

@ikesyo ikesyo force-pushed the project-level-deployment-target branch from 8699142 to 4bbb80c Compare June 23, 2016 04:37
@ikesyo
Copy link
Collaborator Author

ikesyo commented Jun 23, 2016

Done ✨

@ikesyo ikesyo closed this Jun 23, 2016
@ikesyo ikesyo reopened this Jun 23, 2016
@ikesyo ikesyo mentioned this pull request Jun 25, 2016
3 tasks
@ikesyo
Copy link
Collaborator Author

ikesyo commented Jun 25, 2016

Anything else?

@ikesyo ikesyo closed this Jun 27, 2016
@ikesyo ikesyo reopened this Jun 27, 2016
@AliSoftware
Copy link
Owner

Seems ok from what I read from the diff on GitHub, will merge soon — probably tonight — when I have access to my Mac to make a proper test and release.

@AliSoftware
Copy link
Owner

Sorry I've been more busy than I thought in the last few days, and also had to release a new version of SwiftGen in parallel… but rest assured I didn't forget about OHHTTPStubs and this PR 😉

@AliSoftware AliSoftware merged commit b6e4341 into AliSoftware:master Jul 10, 2016
@ikesyo ikesyo deleted the project-level-deployment-target branch July 10, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants