feature: independent runtime root #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
=========================================
- Coverage 69.43% 69.4% -0.03%
=========================================
Files 277 277
Lines 17412 17412
=========================================
- Hits 12090 12085 -5
- Misses 4004 4009 +5
Partials 1318 1318
|
|
Sounds good! |
allencloud
reviewed
Mar 14, 2019
| @@ -540,7 +541,7 @@ func (c *Client) createContainer(ctx context.Context, ref, id, checkpointDir str | |||
| containerd.WithContainerLabels(container.Labels), | |||
| containerd.WithRuntime(fmt.Sprintf("io.containerd.runtime.v1.%s", runtime.GOOS), &runctypes.RuncOptions{ | |||
| Runtime: container.Runtime, | |||
| RuntimeRoot: runtimeRoot, | |||
| RuntimeRoot: path.Join(runtimeRoot, container.Runtime), | |||
There was a problem hiding this comment.
Do we first create this directory or someone would create it if non-exist?
Just confirm.
There was a problem hiding this comment.
Do we first create this directory or someone would create it if non-exist?
Just confirm.
The existence of the path and the security of the join are promised by runtime. 😄
Ace-Tang
approved these changes
Mar 15, 2019
|
LGTM |
pouchrobot
added
the
LGTM
|
We still should check if it is compatible for exist container |
|
I check the containerd shim will keep the runtime root, so it should not effect exist container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhuangqh zhuangqhc@gmail.com
Ⅰ. Describe what this PR did
put different runtime to independent runtime root.
First, distinguish different runtime files. Secondly, it enables v1 containerd-shim to know which runtime to go (hack).
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews