Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feature: independent runtime root" #2758

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Mar 18, 2019

Reverts #2748

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #2758 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2758      +/-   ##
==========================================
- Coverage   69.44%   69.41%   -0.03%     
==========================================
  Files         277      277              
  Lines       17412    17412              
==========================================
- Hits        12091    12087       -4     
- Misses       4000     4002       +2     
- Partials     1321     1323       +2
Flag Coverage Δ
#criv1alpha2_test 39.4% <100%> (-0.02%) ⬇️
#integration_test_0 36.6% <100%> (+0.02%) ⬆️
#integration_test_1 35.8% <100%> (ø) ⬆️
#integration_test_2 36.53% <100%> (ø) ⬆️
#integration_test_3 35.45% <100%> (-0.11%) ⬇️
#node_e2e_test 35.29% <100%> (ø) ⬆️
#unittest 28.51% <0%> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/container.go 56.21% <100%> (-0.39%) ⬇️
cri/v1alpha2/cri.go 71.63% <0%> (-0.26%) ⬇️

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @fuweid
While we thought PR Description could be more specific, longer than 100 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@fuweid Thanks for your contribution. 🍻
Please sign off in each of your commits.

@fuweid
Copy link
Contributor Author

fuweid commented Mar 18, 2019

we need to evaluate the impact to the existing running container. before we have fully tested on this, we revert it first.

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangqh zhuangqh merged commit 788a730 into master Mar 18, 2019
@fuweid fuweid deleted the revert-2748-multi-runtime-root branch March 25, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants