-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
textures: check if the main loop is runing before loading texture #451
Conversation
@AllenDang maybe we can also add |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=========================================
- Coverage 2.91% 2.90% -0.02%
=========================================
Files 30 30
Lines 3123 3136 +13
=========================================
Hits 91 91
- Misses 3032 3045 +13
Continue to review full report at Codecov.
|
this method adds texture to load queue that is processed while running app it allows user to call texture-loading methods inside of main function so that he shouldn't check if texture isn't currently loaded in app loop
well, it should work now. @AllenDang is this inside of Run loop ok? IMO it shouldn't decrease performence or sth... |
or better call this texture-queue processing stuff once an lock |
…(*MasterWindow).Run no idea why is it necessary. everything seems working. I had to forget about removeing something in AllenDang#451 fix AllenDang#494
this should clearify the panic, that appears when user tries to load texture befor calling (*MasterWindow).Run