Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textures: remove panic call when executing NewTexture before calling … #495

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Apr 5, 2022

…(*MasterWindow).Run

no idea why is it necessary. everything seems working.
I had to forget about removeing something in #451

fix #494 and fix #498

…(*MasterWindow).Run

no idea why is it necessary. everything seems working.
I had to forget about removeing something in AllenDang#451

fix AllenDang#494
@codecov-commenter
Copy link

Codecov Report

Merging #495 (783b639) into master (a85dc09) will increase coverage by 0.00%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #495   +/-   ##
======================================
  Coverage    2.88%   2.88%           
======================================
  Files          30      30           
  Lines        3155    3154    -1     
======================================
  Hits           91      91           
+ Misses       3064    3063    -1     
Impacted Files Coverage Δ
Texture.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85dc09...783b639. Read the comment docs.

@AllenDang AllenDang merged commit 1687857 into AllenDang:master Apr 11, 2022
@gucio321 gucio321 deleted the load-textures-panic branch April 11, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example texturefiltering crashing [bug] [bug] Cannot load textures
3 participants