Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch graph checking in SF operations #2271

Closed
t-b opened this issue Oct 1, 2024 · 0 comments · Fixed by #2280
Closed

Ditch graph checking in SF operations #2271

t-b opened this issue Oct 1, 2024 · 0 comments · Fixed by #2280
Assignees
@t-b
Labels
CodeQuality enhancement New feature or request SweepFormula

Comments

@t-b
Copy link
Collaborator

t-b commented Oct 1, 2024

For historical reasons we have a lot of operations which do

	SFH_ASSERT(!IsEmpty(graph), "Graph for extracting sweeps not specified.")

but actually can centralize that in SFH_GetOutputForExecutor which is everyone calling.

Needs to wait for #2109.
@t-b t-b added enhancement New feature or request CodeQuality SweepFormula labels Oct 1, 2024
@t-b t-b self-assigned this Oct 15, 2024
t-b added a commit that referenced this issue Oct 15, 2024
@t-b
MIES_SweepFormula.ipf: Remove emptieness check for graph parameters
ea46ec0 
We never do that for parameters, and usually just let it fail. This is
also here the best choice.

Close #2271
@t-b t-b mentioned this issue Oct 15, 2024
Merged
@t-b t-b closed this as completed in #2280 Oct 16, 2024
@t-b t-b closed this as completed in bdcde24 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-b t-b

Labels
CodeQuality enhancement New feature or request SweepFormula
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sf graph checking AllenInstitute/MIES
1 participant
@t-b