Prep for export recreated epoch info in #2385 #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly from control The comment getter is called from the NWB Export that is also used for old experiments. The previous DAG_GetTextualValue tries to use the GUIState wave that does not know the possibly old control and fails for that case. This workaround (to retrieve the value directly) is a not suited for generic use.
With old data where no result waves exist this caused a lingering RTE. To still be able to use caching the result wave is encapsulated in an always existing wave reference wave. Thus, it does not matter if result is a null wave ref or not.
No functional change
If a user specifies duplicated keys for adding entries in the LNB then the specification is ambiguous.
…ultiplier" In commit 061808a (LNB: Introduce channel type dependent sampling interval entries, 2024-01-09) a change was made that caused the key "Sampling Interval Multiplier" to appear twice in the SweepSettingsKey wave at index 26 and 38 (after that change) Fallout estimation: The writing to the value source wave in DC_DocumentChannelProperty uses FindDimLabel to determine the column, so it writes to 38. The copying in ED_createWaveNotes runs the indexing upwards, such that the last value written to the LBN is read from source index 38. Thus, there should be no side effects. Fix: Removed the entry at index 38 and increased SweepSettings wave version number.
…unctions No functional change
The fallback function tries to retrieve the headstage from the ADC/DAC entries instead.
The constant name is SWEEP_EPOCH_VERSION_ENTRY_KEY
… LBN preparation since e198f96 (Add Utility function GetHeadStageForChannel to get the active HS number, 2021-11-23)
…esult Test_GetHeadstageForChannel checked for TTL channels for INDEP_HEADSTAGE as headstage result, but it must be NaN as TTL channels are not associated. Since 7bcf2c8 (Add LNB function support for TTL channels for read/write, 2023-07-05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge once CI passed.
Needed for #2484.