Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure backwards compatiblity between ophys and pohys modality #61

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bruno-f-cruz
Copy link

@bruno-f-cruz bruno-f-cruz commented Aug 20, 2024

Closes #62
This PR attempts to

  • Ensure that the deserialization of json files using the old "ophys" spec is compatible with the new "pophys" nomenclature.
  • Ensure the previous attribute OPHYS returns a Modality.POPHYS object instead
  • Ensure that from_abbreviation returns a `POPHYS' object if "ophys" is passed as input

We should consider also adding a deprecation warning each time the validator is called, but I will leave that to one of the maintainers.

Linting will fail since the current head of the repo is not properly sanitized. To prevent contaminating the PR diff, I would encourage linting after merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider supporting backwards compatiblity between ophys and pophys
1 participant