Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pin aind data schemas models #49

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

bruno-f-cruz
Copy link
Collaborator

@bruno-f-cruz bruno-f-cruz commented Aug 20, 2024

This PR updates the watchdog to be compatible with aind-data-schemas-models >=0.4.
This update will break compatibility with versions prior to 0.4 since the previous "_abbreviation_map" has now been renamed to "abbreviation_map" and ophys is no longer a valid modality as it has been superseded by pophys.

Closes #48

@bruno-f-cruz bruno-f-cruz changed the base branch from main to development August 20, 2024 20:40
@bruno-f-cruz
Copy link
Collaborator Author

This one would greatly benefit from merging AllenNeuralDynamics/aind-data-schema-models#61 as it would ensure that current rigs running under the old ophys modality would still work.

@bruno-f-cruz
Copy link
Collaborator Author

I decided to also patch it at the level of the watchdog by creating a functional BeforeValidator that coerces ophys into pophys. It is not pretty but since aind-transfer-models also uses its own validation for modalities, seems like the easiest solution for now. We can keep the validation for now and eventually remove it if people indeed stop using it

bruno-f-cruz and others added 6 commits August 20, 2024 15:53
-Add build_watchdog.py

Add hook for aind_data_schema_models

-Update publish_exe.yml

Moves the pyinstaller commandline build to build file module for readability that uses hooks to find hidden imports
Copy link
Collaborator

@arielleleon arielleleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added hook and build file to add in aind-data-schema-models

@arielleleon arielleleon merged commit 95cbb99 into development Aug 22, 2024
@arielleleon arielleleon deleted the build-pin-aind-data-schemas-models branch August 22, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants