Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default data description #783

Merged
merged 13 commits into from
Oct 17, 2024
Merged

Fix default data description #783

merged 13 commits into from
Oct 17, 2024

Conversation

XX-Yin
Copy link
Collaborator

@XX-Yin XX-Yin commented Oct 16, 2024

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

Added the "add_default_project_name" to the settings csv to enable us to turn off the default setting for the project name when the mouse ID is not in the planning spreadsheet.

What issues or discussions does this update address?

resolved #770

Describe the expected change in behavior from the perspective of the experimenter

Please add "add_default_project_name":false to the settings csv if you have your own project information when running mice not in the behavior rig.

Describe any manual update steps for task computers

No

Was this update tested in 446/447?

Tested on my own computer

@alexpiet
Copy link
Collaborator

Can you merge into "develop", instead of main?

@XX-Yin XX-Yin changed the base branch from main to develop October 17, 2024 18:24
@XX-Yin
Copy link
Collaborator Author

XX-Yin commented Oct 17, 2024

Can you merge into "develop", instead of main?

changed

Copy link
Collaborator

@alexpiet alexpiet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking care of this

@XX-Yin XX-Yin merged commit df1dfda into develop Oct 17, 2024
@XX-Yin XX-Yin deleted the fix_data_description branch October 17, 2024 22:58
@alexpiet alexpiet mentioned this pull request Oct 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong project name when the mouse is not in the schedule
2 participants