Skip to content

Feature/superpoint lightglue #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Conversation

hannalee2
Copy link
Collaborator

@hannalee2 hannalee2 commented May 27, 2025

Sorry for the large update! I'll keep the next one smaller for easier review on dev

🚀 Add SuperPoint + LightGlue Reticle Detection with UI and Refactored Worker Threads
This PR introduces a major upgrade to the reticle detection pipeline, including integration of SuperPoint + LightGlue, improved threading, and a redesigned UI. Key updates are as follows:

✨ New Features

  • Implemented SuperPoint + LightGlue-based reticle detection with subprocess execution
  • Added ReticleDetectWidget for UI

🧠 Core Improvements

  • Triangulation is now separated from legacy reticle detection
  • Added interface support for sfm-based detection pipeline
  • Updated to use a thread pool and separated processing and drawing workers (ProcessWorker / DrawWorker)

🧪 Code Quality

  • Added docstrings across the module to achieve 100% interrogate coverage
  • Passed flake8 linting

hannalee2 and others added 30 commits May 5, 2025 13:38
Change file structure + Modularize codes + Fix reticle detection qThread bug. 

- Modularization: MainWindow, control panel, ScreenWidgetManager, reticle_detect_handler, and probe_calibration_handler.

- File Structure: Moved the source codes under the subfolder

- Mock Camera: Implemented multiple mock cameras which can load image or video.

- Reticle Detection: Fixed reticle freeze bug.
…d add 'reticle_detection_cnn' for superpoint + lightglue
While processing, drawing does not run since process API takes a long time.
Drawing is saved in the frame, so it needs to copy
@hannalee2 hannalee2 requested a review from anjaldoshi May 27, 2025 19:57
@hannalee2 hannalee2 requested review from Poofjunior and mah1329 May 27, 2025 20:00
@hannalee2 hannalee2 requested a review from jsiegle May 29, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant