Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for android background location sync #208

Closed
wants to merge 17 commits into from

Conversation

BWMuller
Copy link
Contributor

This should resolve the following issues: #206, #204, #202, #131, #8

This add background location when the app is closed, screen locked or similar as well as start on boot (this requires headless update handler). It also adds more option to the notification such as action and custom channel_id.

Note that one of the changes this does bring in is that when for android someone chooses background location the /method callback for location doesn't trigger anymore due to the headless callback existing. This means that all location updates for android come via the headless handler and for ios come via the getLocationUpdates as they normally do.

Naturally when background location is not enabled then it won't be an issue.

@MoralCode MoralCode mentioned this pull request Jun 19, 2024
@MoralCode
Copy link
Collaborator

@BWMuller thanks for keeping this up to date and sorry for not checking in on this! Was there a particular method you used to test this? I'd love to have some independently verifiable way to know that it works since I cant really directly test it.

@BWMuller
Copy link
Contributor Author

@MoralCode Unfortunately I haven't been able to get around granting permissions as of yet for creating a standalone test that can just be run on ios/android so that you have an independent method of verification

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 25, 2024
Copy link

github-actions bot commented Sep 4, 2024

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants