-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes (see description for details) #203
Conversation
.metadata is from flutter and not eclipse
removed more eclipse project files from the git repository, one of them is the .project file that caused the CI to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, apologies for the delay on getting to this. I approved a PR run to see if this passes CI. Unfortunately I'm in a bit of a tough spot with regards to maintaining this repo (see my comments in #188), largely due to me being unable and/or out of time to thoroughly test each PR. If i could get some more info on how this PR was tested (and maybe some community members to validate that the test procedure works) I'd feel a lot more confident merging this |
Thanks for your response @MoralCode, I appreciate your cautiousness. I created this pull request while I was evaluating this package for my use case. I leave some additional notes if someone wants to take a look at the changes: |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
does #208 address all the issues you had in this PR? |
pendantic
toflutter_lints
and fix lintsLocation
immutable, change time toDateTime