Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes (see description for details) #203

Closed
wants to merge 20 commits into from

Conversation

josxha
Copy link

@josxha josxha commented Mar 26, 2024

  • migrate from deprecated pendantic to flutter_lints and fix lints
  • format code, structure package files, remove leftovers from before null safety
  • remove IDE specific files (eclipse, jetbrains and vscode)
  • remove pubspec.lock files (see https://dart.dev/guides/libraries/private-files#the-rules)
  • make Location immutable, change time to DateTime
  • update gradle to 7.6

@josxha
Copy link
Author

josxha commented Apr 2, 2024

removed more eclipse project files from the git repository, one of them is the .project file that caused the CI to fail.

Copy link
Contributor

@BWMuller BWMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoralCode
Copy link
Collaborator

Hello, apologies for the delay on getting to this. I approved a PR run to see if this passes CI.

Unfortunately I'm in a bit of a tough spot with regards to maintaining this repo (see my comments in #188), largely due to me being unable and/or out of time to thoroughly test each PR.

If i could get some more info on how this PR was tested (and maybe some community members to validate that the test procedure works) I'd feel a lot more confident merging this

@josxha
Copy link
Author

josxha commented Apr 25, 2024

Thanks for your response @MoralCode, I appreciate your cautiousness. I created this pull request while I was evaluating this package for my use case.

I leave some additional notes if someone wants to take a look at the changes:
Most changes have no implication on functionality and are either deleted IDE files or refactoring. The only breaking change is the change of Location.time to be a DateTime (previously int) for improved type safety.

Copy link

github-actions bot commented Jun 9, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Jun 9, 2024
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jun 19, 2024
@MoralCode
Copy link
Collaborator

does #208 address all the issues you had in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants