Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iOS background updates when terminated #207

Closed
wants to merge 1 commit into from

Conversation

zwells
Copy link

@zwells zwells commented Apr 4, 2024

This PR enables the ability for the app to be woken up and trigger the callback even when terminated once iOS detects a significant location change (200 - 500 meters). Tested and working.

  • 'background_location\ios\Classes\SwiftBackgroundLocationPlugin.swift' = Added lines
24 SwiftBackgroundLocationPlugin.locationManager?.startMonitoringSignificantLocationChanges()

This PR enables the ability for the app to be woken up and trigger the callback even when terminated once the OS detects a significant location change (200 - 500 meters). Tested and working.
@simplylizz
Copy link

Is this going to be merged? It would be nice to have it in the main branch.

@MoralCode
Copy link
Collaborator

Is this going to be merged? It would be nice to have it in the main branch.

While I can merge it, I'm sorta unsure what to do with the limited time that I have (see my comments in #188). The volume of conversation happening on issues and PRs on this repo makes me suspect there's a fairly large userbase of this library (since typically only a small minority ends up speaking up in issues and PRs like this), which makes me hesitant to blindly merge stuff for fear of breaking things. This is especially true since I don't really use this library anymore and dont really have a great testing setup that would allow me to efficiently validate PRs to the level of quality this community probably expects. In all honestly I largely just wanted to step in to help since it seemed like @Almoullim is also in a similar position of not having time.

If there were something like automated test cases that had good coverage or like a detailed/step by step testing methodology that interested community members could run and post comments verifying that it works for them, that would definitely give me more confidence that things aren't going to break by merging PRs.

I'm sorry I don't have better news - as far as i can tell this repo has been on maintainership life support for a while

@simplylizz
Copy link

The volume of conversation happening on issues and PRs on this repo makes me suspect there's a fairly large userbase of this library (since typically only a small minority ends up speaking up in issues and PRs like this)

Can say only for myself: actually I wouldn't consider myself as a part of this user base. I'm only building my first iOS PoC for a side project and I'm not a mobile/flutter dev at all. But why I asked: apparently I need this feature, but there is simply no flutter package for geolocation which could handle background updates well (I've tried flutter-location, geolocator and had a look on a few others).

In context of this PR: I already made a fork and added this and a few other changes to the package. So if this package is unmaintained then I don't care if this particular change would be merged or not.

P.S. Maybe it's worth updating readme file and adding a note that the package isn't actively maintained and add a reference to #188.

Copy link

github-actions bot commented Jun 9, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Jun 9, 2024
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jun 19, 2024
@MoralCode MoralCode mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants