Simplify and fix SystemView slide scrolling logic #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looping around the ends becomes much simpler if we take mScrollVelocity into account, as it tells us which way we're supposed to be scrolling. The existing method works if you wait for the transition to finish before scrolling to the next item, but if you press the arrows too quickly you'll zoom from end->start rather than wrapping.
joolswills
added a commit
to joolswills/EmulationStation
that referenced
this pull request
Feb 8, 2019
Fixes for issues Aloshi#503 and Aloshi#505.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looping around the ends becomes much simpler if we take mScrollVelocity into account, as it tells us which way we're supposed to be scrolling.
The existing method works if you wait for the transition to finish before scrolling to the next item, but if you press the arrows too quickly you'll zoom the wrong way rather than wrapping.