Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and MSVC 2015 fixes #507

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sorting and MSVC 2015 fixes #507

wants to merge 3 commits into from

Conversation

aslater
Copy link

@aslater aslater commented Aug 30, 2015

I've got three commits in this pull request:

  • 276a207: when sorting by rating or playcount, if two files are tied, break the tie with compareFileName
  • 5748744: Get the project compiling in MSVC 2015 Community (I'm not sure whether these were all necessary or if I could've gotten around them)
    ** Add WinMain when compiling in MSVC
    ** Define __iob_func for compatibility with older DLLs
    ** Wrap the declaration of round() in the same preprocessor check as its implementation
  • ce00f5f: Make the sort type persistent by storing the sort ID in a new gamelist attribute ("sortid")

How do they look?

Thanks,

-- Adam Slater

@aslater
Copy link
Author

aslater commented Aug 30, 2015

Aaand...wrong flavor of markdown; sorry about that.

  • 5748744: Get the project compiling in MSVC 2015 Community (I'm not sure whether these were all necessary or if I could've gotten around them)
    • Add WinMain when compiling in MSVC
    • Define __iob_func for compatibility with older DLLs
    • Wrap the declaration of round() in the same preprocessor check as its implementation

joolswills added a commit to joolswills/EmulationStation that referenced this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant