-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final API23 (Android 6) Support Release #2699
base: master
Are you sure you want to change the base?
Conversation
@@ -226,8 +228,9 @@ dependencies { | |||
implementation 'com.github.apl-devs:appintro:v4.2.2' | |||
implementation 'com.romandanylyk:pageindicatorview:1.0.0' | |||
|
|||
//coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.0.5' | |||
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning |
|
---|---|
📚 | A newer version of com.android.tools:desugar_jdk_libs than 1.1.5 is available: 1.2.0 |
🛠️ | GradleDependency |
by Android Lint 🤖
@@ -226,8 +228,9 @@ dependencies { | |||
implementation 'com.github.apl-devs:appintro:v4.2.2' | |||
implementation 'com.romandanylyk:pageindicatorview:1.0.0' | |||
|
|||
//coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.0.5' | |||
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning |
|
---|---|
📚 | A newer version of com.android.tools:desugar_jdk_libs than 1.1.5 is available: 1.2.0 |
🛠️ | GradleDependency |
by Android Lint 🤖
525eba1
to
4b2d63b
Compare
3f68db6
to
545ea45
Compare
Codecov ReportBase: 7.46% // Head: 7.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2699 +/- ##
===========================================
- Coverage 7.46% 7.45% -0.01%
Complexity 790 790
===========================================
Files 579 579
Lines 40892 40912 +20
Branches 4180 4181 +1
===========================================
Hits 3052 3052
- Misses 37576 37596 +20
Partials 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
545ea45
to
b22f8c5
Compare
e967340
to
32f6049
Compare
* Fix NPEs
* Shift to using type interface for IPFSService to make it possible to implement IO-free unit tests * Update IPFS usage and add unit testing for new service. * Fix certificate test * Updates as suggested
a1cfb4f
to
8acd3f7
Compare
…ace TokenScript usage of primary with dappbrowser RPC
…ace TokenScript usage of primary with dappbrowser RPC
4e9565d
to
6068cf5
Compare
Fixes #2636