Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final API23 (Android 6) Support Release #2699

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

asif-finimble
Copy link
Contributor

Fixes #2636

@@ -226,8 +228,9 @@ dependencies {
implementation 'com.github.apl-devs:appintro:v4.2.2'
implementation 'com.romandanylyk:pageindicatorview:1.0.0'

//coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.0.5'
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning ⚠️  
📚 A newer version of com.android.tools:desugar_jdk_libs than 1.1.5 is available: 1.2.0
🛠️ GradleDependency

by Android Lint 🤖

@@ -226,8 +228,9 @@ dependencies {
implementation 'com.github.apl-devs:appintro:v4.2.2'
implementation 'com.romandanylyk:pageindicatorview:1.0.0'

//coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.0.5'
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning ⚠️  
📚 A newer version of com.android.tools:desugar_jdk_libs than 1.1.5 is available: 1.2.0
🛠️ GradleDependency

by Android Lint 🤖

@seabornlee seabornlee closed this Aug 26, 2022
@seabornlee seabornlee reopened this Aug 30, 2022
@JamesSmartCell JamesSmartCell force-pushed the 2636_api_23_crashfix branch 2 times, most recently from 525eba1 to 4b2d63b Compare September 21, 2022 01:34
@JamesSmartCell JamesSmartCell added API23 Release Working branch for final API23 release Archive Branch labels Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 7.46% // Head: 7.45% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5cc4bf7) compared to base (278da3c).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 5cc4bf7 differs from pull request most recent head dcbc9ae. Consider uploading reports for the commit dcbc9ae to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2699      +/-   ##
===========================================
- Coverage      7.46%   7.45%   -0.01%     
  Complexity      790     790              
===========================================
  Files           579     579              
  Lines         40892   40912      +20     
  Branches       4180    4181       +1     
===========================================
  Hits           3052    3052              
- Misses        37576   37596      +20     
  Partials        264     264              
Impacted Files Coverage Δ
...let/app/repository/SharedPreferenceRepository.java 37.14% <0.00%> (-1.10%) ⬇️
...va/com/alphawallet/app/ui/NewSettingsFragment.java 0.00% <0.00%> (ø)
...in/java/com/alphawallet/app/ui/WalletFragment.java 1.97% <0.00%> (+<0.01%) ⬆️
...lphawallet/app/viewmodel/NewSettingsViewModel.java 28.84% <0.00%> (-0.57%) ⬇️
...llet/app/viewmodel/TransactionDetailViewModel.java 0.00% <0.00%> (ø)
...c/main/java/com/alphawallet/app/web3/Web3View.java 16.89% <0.00%> (-1.10%) ⬇️
...n/java/com/alphawallet/app/widget/InputAmount.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesSmartCell JamesSmartCell changed the title api 23 crashfix Final API23 (Android 6) Support Release Sep 28, 2022
@JamesSmartCell JamesSmartCell force-pushed the master branch 2 times, most recently from a1cfb4f to 8acd3f7 Compare December 7, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API23 Release Working branch for final API23 release Archive Branch Do Not Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnose API23 crash issue
4 participants