Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve RBAC restore when /var/lib/clickhouse/access is already contains .sql #851

Closed
Slach opened this issue Feb 23, 2024 · 2 comments · Fixed by #843
Closed

improve RBAC restore when /var/lib/clickhouse/access is already contains .sql #851

Slach opened this issue Feb 23, 2024 · 2 comments · Fixed by #843
Assignees
@Slach
Milestone
2.5.0

Comments

@Slach
Copy link
Collaborator

Slach commented Feb 23, 2024 •
edited
Loading

  • need parse exists /var/lib/clickhouse/access/*.sql to find conflict type and name
  • merge backup_name/access/.sql and /var/lib/clickhouse/access/.sql
  • thinks about jsonl zookeeper data
@Slach Slach self-assigned this Feb 23, 2024
@Slach Slach added this to the 2.5.0 milestone Feb 23, 2024
@minguyen9988
Copy link
Contributor

thanks, it will smoothen the rbac process a lot, ultimately, this should be able to clone clickhouse like for like in use case like prod to dev rebuild, host rebuild, etc ...

@Slach
Copy link
Collaborator Author

Slach commented Apr 1, 2024

duplicated with #793

@Slach Slach closed this as completed Apr 1, 2024
Slach added a commit that referenced this issue Apr 3, 2024
@Slach
- added rbac_conflict_resolution: recreate option for RBAC object n…
a9dcc50 
…ame conflicts during restore, fix #851
@Slach Slach mentioned this issue Apr 3, 2024
Merged
Slach added a commit that referenced this issue Apr 3, 2024
@Slach
modified rbac_conflict_resolution: recreate option for RBAC object …
da96a29 
…name conflicts during restore, fix #851, change approach to SQL based
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Slach Slach

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

prepare v2.5 Altinity/clickhouse-backup
2 participants
@Slach @minguyen9988