-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare v2.5 #843
Merged
prepare v2.5 #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ReadMe.md # pkg/config/config.go
…ow RBAC, Configs for Embedded Backup
…reBlobStorage(), still not work, look Azure/Azurite#2053, ClickHouse/ClickHouse#52088
…reBlobStorage(), still not work, clickhouse-server don't close connection properly after FIN from azurite during BACKUP/RESTORE ClickHouse/ClickHouse#60447
…reBlobStorage(), still not work, clickhouse-server don't close connection properly after FIN from azurite during BACKUP/RESTORE ClickHouse/ClickHouse#60447
Pull Request Test Coverage Report for Build 8590641064Details
💛 - Coveralls |
…t when XML-API will implement on fsouza/fake-gcs-server#1164, fsouza/fake-gcs-server#1330
…edded_backup_disk` value, tested on S3/GCS over S3/AzureBlobStorage, fix #695
…`restore` and `restore_remote` with parameters `--data --partitions=...`, fix #756
…`restore` and `restore_remote` with parameters `--data --partitions=...`, fix #756
…`restore` and `restore_remote` with parameters `--data --partitions=...`, fix #756
…..` corner case for #756
…use `allow_non_empty_tables=true` to allow fix #756
…mically override any config parameter, fix #821
… parameter for allow dynamically override any config parameter, fix #821
This was referenced Apr 3, 2024
…ame conflicts during restore, fix #851
…e` - will never upload object disk content, fix #799
…name conflicts during restore, fix #851, change approach to SQL based
…server prior 22.3
…erver startup time and `docker-entrypoint.d` processing, will infinite reconnect each 5 seconds, until success, fix #857
… disk with type `local`, fix #882, asd complete removed support for legacy backups, created with version prior v1.0
…th not only default disk to find pratially created backups, fix #873 fixed create `--rbac` behavior, don't create access folder if no RBAC objects is present
…in any `storage_policies`, fix #845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPROVEMENTS
disable_progress_bar
config option and related progress bar code--delete-source
parameter forupload
andcreate_remote
commands to explicitly delete local backup during upload, fix 777--env ENV_NAME=value
cli parameter for allow dynamically override any config parameter, fix 821use_embedded_backup_restore: true
with emptyembedded_backup_disk
value, tested on S3/GCS over S3/AzureBlobStorage, fix 695--rbac, --rbac-only, --configs, --configs-only
now works withuse_embedded_backup_restore: true
--
--data
forrestore
withuse_embedded_backup_restore: true
will useallow_non_empty_tables=true
to allow fix 756--diff-from-remote
parameter forcreate
command, will copy only new data parts object disk data, also allows to download properly object disk data from required backup duringrestore
, fix 865use_embedded_backup_restore: true
fix 735GCS_CHUNK_SIZE
config parameter, try to speedup GCS upload fix 874, thanks @dermasmid--remote-backup
cli parameter totables
command andGET /backup/table
, fix 778rbac_always_backup: true
option to default config, will create backup for RBAC objects automatically, restore still require--rbac
to avoid destructive actions, fix 793rbac_conflict_resolution: recreate
option for RBAC object name conflicts during restore, fix 851upload_max_bytes_per_seconds
anddownload_max_bytes_per_seconds
config options to allow throttling without CAP_SYS_NICE, fix 817clickhouse_backup_in_progress_commands
metric, fix 836clickhouse/clickhouse-server:24.3
to CI/CDBUG FIXES
S3_MAX_PARTS_COUNT
default value from2000
to4000
to continue decrease memory usage for S35Mb
to10Mb
ALTER TABLE ... DROP PARTITION
instead ofDROP TABLE
forrestore
andrestore_remote
with parameters--data --partitions=...
, fix 756freeze_by_part
+freeze_by_part_where
, fix 855CLICKHOUSE_SKIP_TABLES_ENGINES
duringcreate
commandObjectDisks
+CLICKHOUSE_USE_EMBEDDED_BACKUP_RESTORE: true
- shall skip upload object disk content, fix 799docker-entrypoint.d
processing, will infinite reconnect each 5 seconds, until success, fix 857USE_EMBEDDED_BACKUP_RESTORE=true
behavior to allow use backup disk with typelocal
, fix 882--rbac
behavior, don't create access folder if no RBAC objects is presentsystem.disks
contains disk which not present in anystorage_policies
, fix 845