Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement component for grid property setting #11736

Closed
Tracked by #7540
nkylstad opened this issue Nov 30, 2023 · 2 comments · Fixed by #11851
Closed
Tracked by #7540

Implement component for grid property setting #11736

nkylstad opened this issue Nov 30, 2023 · 2 comments · Fixed by #11851
Assignees

Comments

@nkylstad
Copy link
Member

nkylstad commented Nov 30, 2023

Description

Use POC developed in https://codesandbox.io/p/sandbox/ecstatic-poitras-d4hchd?file=%2Fsrc%2FApp.tsx%3A15%2C29 as basis. Use Studio colors, check with @Annikenkbrathen .

We add the component as a pure component in studio-components.

@nkylstad nkylstad moved this to 📈 Todo in Team Studio Dec 4, 2023
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 5, 2023
@standeren standeren self-assigned this Dec 5, 2023
@Annikenkbrathen Annikenkbrathen moved this to Todo 📈 in Design Altinn 3 Dec 6, 2023
@Annikenkbrathen
Copy link

Annikenkbrathen commented Dec 8, 2023

We can use the primary and secondary button colors for this component. The primary button has two states: Default and hover, and the secondary has one, default. I think this will work well for this case.

Here is number 1-6 sat as default, number 7 is hovered, and 8-12 is secondary buttons on default

Skjermbilde 2023-12-08 kl  14 17 09
grid.mov

@standeren standeren linked a pull request Dec 13, 2023 that will close this issue
3 tasks
@Annikenkbrathen Annikenkbrathen moved this from Todo 📈 to Done 🏁 in Design Altinn 3 Dec 14, 2023
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 19, 2023
@standeren standeren removed their assignment Dec 19, 2023
@framitdavid framitdavid self-assigned this Dec 19, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jan 4, 2024
@framitdavid
Copy link
Collaborator

Successfully tested in dev! Additionally, confirmed that the committed files appear correctly in Gitea. 👏

@framitdavid framitdavid moved this from 🧪 Test to ✅ Done in Team Studio Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants