-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11736 implement component for grid property setting #11851
11736 implement component for grid property setting #11851
Conversation
c0de6d0
to
2069153
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11851 +/- ##
==========================================
- Coverage 86.93% 86.93% -0.01%
==========================================
Files 929 936 +7
Lines 13180 13310 +130
Branches 1608 1632 +24
==========================================
+ Hits 11458 11571 +113
- Misses 1507 1521 +14
- Partials 215 218 +3 ☔ View full report in Codecov by Sentry. |
7da5bb5
to
adec8d9
Compare
4f4fff9
to
733d832
Compare
4d66343
to
b08195c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have accomplished a huge amount of excellent work! 🚀 👏 I have a suggestion that I'd like to put forward, but feel free to disagree. It's possible that I may have misunderstood certain aspects. 😎
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.test.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditGrid.tsx
Outdated
Show resolved
Hide resolved
I'm almost done with the review, but I need to continue with the last part tomorrow. However, once again, I like what I see here. 🤩 |
frontend/packages/ux-editor/src/components/config/editModal/EditGrid/utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditGrid/types/ViewSize.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditGrid/utils.test.ts
Show resolved
Hide resolved
0b159f2
to
bdf872e
Compare
dc14465
to
8a8f224
Compare
8a8f224
to
721ee79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veldig fint løst hover-effekt, har bare noen små endringsforslag.
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioGridSelector/StudioGridSelector.tsx
Outdated
Show resolved
Hide resolved
dcc89bd
to
41cd9e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formidabelt.
Description
Screen.Recording.2023-12-19.at.14.09.42.mov
Large screen
Disabled:
Enabled:
This PR does not take
LabelGrid
andInnerGrid
into account. It only cares about the main grid for the selected componentVerification