Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11736 implement component for grid property setting #11851

Merged
merged 18 commits into from
Jan 4, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Dec 13, 2023

Description

  • Add a StudioComponent named StudioSlider which is a slider with intervals from 1-12
  • Add a EditGrid component used in Form component config that renders a possibility to select a viewSize where the selected view size is passed down to a new component named EditGridForGivenViewSize
  • Add a EditGridForGivenViewSize component that renders the StudioSlider and a switch, where the switch can set the grid-property to use default value which is 12. Setting this will remove the grid-value for the particular view size from the layoutfile.
Screen.Recording.2023-12-19.at.14.09.42.mov

Large screen

Disabled:
Screenshot 2023-12-19 at 14 11 15

Enabled:
Screenshot 2023-12-19 at 14 12 00

This PR does not take LabelGrid and InnerGrid into account. It only cares about the main grid for the selected component

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Dec 13, 2023 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 13, 2023
@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch 2 times, most recently from c0de6d0 to 2069153 Compare December 14, 2023 09:10
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (97bab35) 86.93% compared to head (41cd9e1) 86.93%.
Report is 8 commits behind head on master.

Files Patch % Lines
...mponents/StudioGridSelector/StudioGridSelector.tsx 72.88% 14 Missing and 2 partials ⚠️
...itor/src/components/config/FormComponentConfig.tsx 85.71% 1 Missing ⚠️
.../components/config/editModal/EditGrid/EditGrid.tsx 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11851      +/-   ##
==========================================
- Coverage   86.93%   86.93%   -0.01%     
==========================================
  Files         929      936       +7     
  Lines       13180    13310     +130     
  Branches     1608     1632      +24     
==========================================
+ Hits        11458    11571     +113     
- Misses       1507     1521      +14     
- Partials      215      218       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch 5 times, most recently from 7da5bb5 to adec8d9 Compare December 19, 2023 13:08
@standeren standeren marked this pull request as ready for review December 19, 2023 13:14
@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch from 4f4fff9 to 733d832 Compare December 19, 2023 14:06
@standeren standeren linked an issue Dec 19, 2023 that may be closed by this pull request
@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch 3 times, most recently from 4d66343 to b08195c Compare December 19, 2023 15:45
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have accomplished a huge amount of excellent work! 🚀 👏 I have a suggestion that I'd like to put forward, but feel free to disagree. It's possible that I may have misunderstood certain aspects. 😎

@framitdavid
Copy link
Collaborator

I'm almost done with the review, but I need to continue with the last part tomorrow. However, once again, I like what I see here. 🤩

@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch from 0b159f2 to bdf872e Compare January 3, 2024 14:18
@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch from dc14465 to 8a8f224 Compare January 4, 2024 13:26
@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch from 8a8f224 to 721ee79 Compare January 4, 2024 13:41
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig fint løst hover-effekt, har bare noen små endringsforslag.

@standeren standeren force-pushed the 11736-implement-component-for-grid-property-setting branch from dcc89bd to 41cd9e1 Compare January 4, 2024 14:37
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formidabelt.

@standeren standeren merged commit 5a39a6e into master Jan 4, 2024
9 of 10 checks passed
@standeren standeren deleted the 11736-implement-component-for-grid-property-setting branch January 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grid property component to component config Implement component for grid property setting
3 participants