Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'One of the rows is incorrectly filled out' message #547

Closed
olemartinorg opened this issue Oct 17, 2022 · 0 comments · Fixed by #588
Closed

Remove 'One of the rows is incorrectly filled out' message #547

olemartinorg opened this issue Oct 17, 2022 · 0 comments · Fixed by #588

Comments

@olemartinorg
Copy link
Contributor

Background

After #100, and with the errors already showing up in the repeating group table overview, this error message is unnecessary.

en-av-radene-fyllt-ut-riktig

It also follows an older design for error messages.
@olemartinorg olemartinorg moved this to 📈 Todo in Team Apps Oct 17, 2022
@bjosttveit bjosttveit self-assigned this Oct 26, 2022
@bjosttveit bjosttveit moved this from 📈 Todo to 👷 In Progress in Team Apps Oct 26, 2022
bjosttveit added a commit that referenced this issue Oct 26, 2022
@bjosttveit
Fixes #547
dcf7504
@bjosttveit bjosttveit mentioned this issue Oct 28, 2022
Merged
4 tasks
@bjosttveit bjosttveit linked a pull request Oct 28, 2022 that will close this issue
Fix/repeating groups validation #588
Merged
4 tasks
@bjosttveit bjosttveit moved this from 👷 In Progress to 🔎 Review in Team Apps Oct 28, 2022
bjosttveit added a commit that referenced this issue Oct 31, 2022
@bjosttveit
Fix/repeating groups validation (#588)
7802a21 
* Fixes #547

* Fixes #548

* update tests

* removed onClickSave and updated jest tests

* tiny refactor

* fix nested group id

* Attempt at adding multiPageIndex to the hierarchy components

Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Repository owner moved this from 🔎 Review to ✅ Done in Team Apps Oct 31, 2022
@bjosttveit bjosttveit removed their assignment Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/repeating groups validation Altinn/app-frontend-react
2 participants
@olemartinorg @bjosttveit