Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/repeating groups validation #588

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Fix/repeating groups validation #588

merged 7 commits into from
Oct 31, 2022

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Oct 28, 2022 •
edited
Loading

Description

  1. Removed this warning
    image
  2. Navigating to error message will now open the repeating group rows for editing and navigate to the correct multiPage
  3. Also fixes an issue related to deleting validation when a row (with multiPage) is deleted

Note: One behavior was changed which required updating the cypress tests in attatchments-in-group. Previously, clicking save and close in the table row (not edit container) would not reset the multiPageIndex to 0. This would however happen if the save button inside the edit container was clicked. This has been changed so that in both cases, the multiPageindex is set to 0 when clicking save and close. The changes in cypress tests groups was just removing the old warning message.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

This was linked to issues Oct 28, 2022
Remove 'One of the rows is incorrectly filled out' message #547
Closed
Navigating to an error message in a repeating group should open the row for editing #548
Closed
@github-actions github-actions bot added the area/test related to automated and functional testing label Oct 28, 2022
@bjosttveit bjosttveit marked this pull request as ready for review October 28, 2022 13:03
olemartinorg
olemartinorg approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

src/altinn-app-frontend/src/components/message/ErrorReport.tsx Outdated Show resolved Hide resolved
src/altinn-app-frontend/src/components/message/ErrorReport.tsx Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

66.4% 66.4% Coverage
0.0% 0.0% Duplication

@bjosttveit bjosttveit merged commit 7802a21 into main Oct 31, 2022
@bjosttveit bjosttveit deleted the fix/repeating-groups-validation branch October 31, 2022 07:46
@olemartinorg olemartinorg added the kind/bug Something isn't working label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemartinorg olemartinorg olemartinorg approved these changes

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

Assignees
No one assigned
Labels
area/test related to automated and functional testing kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@bjosttveit @olemartinorg