Variables in text. Empty variables in will display path to datasource.

[tronberg]

Description of the bug

If a variable's datasource is empty, the path to the datasource will be displayed.

Steps To Reproduce

Clone and run app ra0182.

Additional Information

No response

[olemartinorg]

In the long term, we hope to replace these variables with dynamic expressions. With expressions, it's possible to control what gets displayed if the value is empty. Right now (even in your screenshot example), there is no proper default. Displaying an empty string is a bit better - but it's still not optimal. We could, of course, figure out that the field is formatted as a number (or uses a number type in the data model) and assume 0 is a good default - but at that point, implementing expressions instead is probably easier.

You can fix this in your app at when using the latest main (which will be released as a proper version today or tomorrow), by controlling this using expressions in the text resource bindings themselves.

[olemartinorg]

As an easier quick-fix, I believe we should support a default parameter (in plain text, or possibly other text keys - if easy to implement).

{
  "id": "entityInfoBusinessId",
  "value": "Business ID: {0}",
  "variables": [
    {
      "key": "EntityInfo.BusinessId",
      "dataSource": "dataModel.default",
      "default": "(missing value)" // <--------- New parameter
    }
  ]
},

This might have consequences for Studio, so we should make sure Studio doesn't clean these up for us. It's also relevant for the possible future language file format, where references to the data model will change at some point (@mjulstein @mijohansen @TomasEng @andrealouisestanderen).

[FinnurO]

Kunne man brukt shortname brukt i validering, eller samme mønster, for å sette inn default tekst? Eller bruke teksten på feltet man skal hente verdien fra? @olemartinorg

[olemartinorg]

Tekstnøklene har ikke en 1-1-relasjon med komponentene, så det blir ikke naturlig å putte shortName eller lignende som default-verdi for et oppslag som feiler i disse variablene. Med det sagt, vi har en god workaround for dette problemet på plass nå, som er mer fleksibel enn det jeg foreslo 13. januar.

Vi støtter nå dynamiske uttrykk på alle verdiene i textResourceBindings. Så for å gjenbruke eksempelet vi har over:

[
  {
    "id": "entityInfoBusinessId",
    "value": "Business ID: {0}",
    "variables": [
      {
        "key": "EntityInfo.BusinessId",
        "dataSource": "dataModel.default"
      }
    ]
  },
  {
    "id": "entityInfoBusinessIdNotFound" // <--- Lagt til
    "value": "Business ID not found",
  }
]

Og i layout-fila:

{
  "id": "abc123",
  "type": "Header",
  "textResourceBindings": {
    "title": [
      "if"
      ["equals", ["dataModel", "EntityInfo.BusinessId"], null]
      "entityInfoBusinessIdNotFound",
      "else",
      "entityInfoBusinessId"
    ]
  }
}

Med andre ord, man kan nå bruke uttrykk for å bytte mellom forskjellige tekstressurser, avhengig av f.eks. verdien som ligger i datamodellen. En manglende verdi vil være lik null i uttrykk-språket.

[olemartinorg]

Implemented now. See these PRs for details:

• Tech debt: Language variables rewrite #1444
• feat(TextResources): add support for defaultValue in variables in tex… #1441
• fix: if defaultValue in text variables is set to empty string, the ap… #1596