-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextResources): add support for defaultValue in variables in tex… #1441
Conversation
I'm assuming this relies on #1444 to be merged? In that case we should wait until the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We should include config for this in frontend-test
those places we know of, so that Percy picks it up in screenshots.
@mikaelrss #1444 has been merged - maybe this should be rebased against main? 🙏 |
Yeah. I'll fix it! |
d14148f
to
078b19b
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR adds support for a defaultValue option in variables in text resources. This would allow for app developers to provide a value to print if the variable points to a null-value in the datamodel. The current behavior is that the app displays the path to the datamodel.
Related Issue(s)
PR in storage:
Verification/QA
kind/*
label to this PR for proper release notes grouping