Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextResources): add support for defaultValue in variables in tex… #1441

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Sep 8, 2023

Description

This PR adds support for a defaultValue option in variables in text resources. This would allow for app developers to provide a value to print if the variable points to a null-value in the datamodel. The current behavior is that the app displays the path to the datamodel.

Related Issue(s)

PR in storage:

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@mikaelrss mikaelrss marked this pull request as ready for review September 11, 2023 08:11
@olemartinorg
Copy link
Contributor

I'm assuming this relies on #1444 to be merged? In that case we should wait until the v3 branch is made (and the last big minor version of v3 is released this week) before we merge this.

@olemartinorg olemartinorg added the kind/product-feature Pull requests containing new features label Sep 11, 2023
@mikaelrss
Copy link
Contributor Author

I'm assuming this relies on #1444 to be merged? In that case we should wait until the v3 branch is made (and the last big minor version of v3 is released this week) before we merge this.

Yes, definitely. It's got the branch of #1444 as base. But it can be reviewed already.

Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should include config for this in frontend-test those places we know of, so that Percy picks it up in screenshots.

Base automatically changed from fix/1218-language-support-tech-debt to main September 13, 2023 12:15
@olemartinorg
Copy link
Contributor

@mikaelrss #1444 has been merged - maybe this should be rebased against main? 🙏

@mikaelrss
Copy link
Contributor Author

Yeah. I'll fix it!

@mikaelrss mikaelrss force-pushed the feat/default-value-in-variables branch from d14148f to 078b19b Compare September 13, 2023 12:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

20.0% 20.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add defaultValue option to variables in text
3 participants