Tech debt: Language variables rewrite #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resources on-the-fly. Remove replaceTextResources saga
…ject (such as on the Confirm page, which we luckily had tests for)
…ting in selector returning new reference each render
…e fixing the mocks)
… from the data model instead
…tions from useGetOptions if they are defined over optionsId
…ebt' into fix/1218-language-support-tech-debt # Conflicts: # src/layout/Group/GroupContainer.test.tsx
… property deduce which path in the data model to use. Not sure about the performance impact of this.
…ebt' into fix/1218-language-support-tech-debt
…ebt' into fix/1218-language-support-tech-debt
19 tasks
olemartinorg
added
the
kind/breaking-change
|
The failing cypress test should be fixed in #1443, and the percy changes points at some of the breaking changes in this PR |
Closed
# Conflicts: # .github/workflows/codeql.yml
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrites language logic such that the
useLanguage-hook is used for resolving variables in text resources for repeating groups.Breaking changes:
Previously, when a path to the data model resulted in a
null-value, the code that handled printing text in options of groups would print an empty string. Since we've rewritten the language printing to utilize theuseLanguage-hooks, this behavior has now changed. Instead of filtering out the variable path, the path will now be printed (which is what is done everywhere else in the application).Example:
Previous version of frontend:
Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping