Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with organisation logo not taking the available space #1443

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Sep 11, 2023

Description

This PR fixes an issue where some organisation logos would not take the available space (and getting width 0 and height 0)

It also fixes an issue with a flaky cypress test in frontend/validations.ts. The test failed because there was a race condition on validating repeating groups. Because of a takeLatest in the updateRepeatingGroupsEditIndex action. This meant that if there was an already ongoing validation that had not yet fulfilled, this would be dropped, causing the application to ignore a validation error.

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@mikaelrss mikaelrss added the kind/bug Something isn't working label Sep 11, 2023
@mikaelrss mikaelrss self-assigned this Sep 11, 2023
@mikaelrss mikaelrss marked this pull request as ready for review September 11, 2023 12:36
…tIndex. This solves a bug where there was a race condition on validating multiple rows in repeating groups
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mikaelrss mikaelrss merged commit 18ede8d into main Sep 12, 2023
@mikaelrss mikaelrss deleted the fix/org-logo-does-not-take-available-space branch September 12, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants