Grid component #1118
Merged
Grid component #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 27, 2023 10:07
…, this should be `ExprVal.String`, but that won't work great with the expression defaults, the way they are defined right now (they have no support for expressions inside array structures, such as `rows`). Deferring this part of the task.
… to support Grid
… to support Grid
# Conflicts: # src/components/summary/SummaryGroupComponent.tsx # src/features/form/containers/RepeatingGroupsEditContainer.tsx # src/layout/index.ts # src/utils/layout/hierarchy.ts # test/e2e/integration/app-frontend/summary.ts
…ays. Fixing the readOnly color, as it didn't match the input field.
# Conflicts: # src/layout/GenericComponent.tsx
…an't resolve it), and somebody _did_ rewrite the FullWidthWrapper to css modules! Hooray!
…de a node. The returned result will narrow the type of `this`.
…nto separate files
…g existing function that does this).
…ons upon every tiny little state change
…trial and error, I got it working fairly well. Rewriting the layout hierarchy generator to a more modularized one. With this change, we can have infinite levels of repeating groups (in theory, at least).
# Conflicts: # src/layout/Checkboxes/CheckboxesContainerComponent.tsx # src/layout/RadioButtons/ControlledRadioGroup.tsx # src/layout/index.ts
…he same as false.
# Conflicts: # src/features/pdf/PDFView.tsx # src/features/pdf/data/generatePdfSagas.ts # src/layout/Group/RepeatingGroupTable.tsx # src/layout/Group/RepeatingGroupTableRow.tsx # src/layout/Group/RepeatingGroupsEditContainer.tsx # src/layout/Group/SummaryGroupComponent.tsx # src/layout/Group/index.tsx # src/layout/LayoutComponent.tsx # src/layout/Summary/SummaryBoilerplate.tsx # src/layout/Summary/SummaryComponent.tsx # src/utils/layout/LayoutNode.ts # src/utils/layout/hierarchy.test.ts # src/utils/layout/hierarchy.ts
# Conflicts: # src/utils/layout/hierarchy.ts # src/utils/layout/hierarchy.types.d.ts # test/e2e/integration/app-frontend/components.ts # test/e2e/support/navigation.ts
…component than the Panel component
…implemented. One instance is always re-used for every component type, so that we can store state inside it to make group panel references easier to implement.
added 17 commits
April 17, 2023 15:35
…ular components (but hiding header and readOnly rows)
…he actual target component, not the original grid reference
… was missing the 'empty summary' implementation.
…o the first page to fill out the form without going to the last page again before the sendIn button is clicked.
… This also unhides the components in headers and readOnly rows, making the mobile navigation.ts test work properly.
…rt radio group now was affected when in mobile mode. Restricting the change to only come into effect when rendered in a table/grid.
…der cell (and all other cells) because of object re-use.
# Conflicts: # src/components/Select.tsx # src/layout/Checkboxes/CheckboxesContainerComponent.tsx # src/layout/Dropdown/DropdownComponent.tsx # src/layout/MultipleSelect/MultipleSelectComponent.tsx # src/layout/RadioButtons/ControlledRadioGroup.tsx # test/e2e/integration/app-frontend/components.ts # test/e2e/integration/app-frontend/dynamics.ts # test/e2e/integration/app-frontend/summary.ts
olemartinorg
added
the
kind/product-feature
|
SonarCloud Quality Gate failed. |
olemartinorg
requested review from
Magnusrm,
framitdavid,
bjosttveit and
lassopicasso
framitdavid
approved these changes
Apr 26, 2023
bjosttveit
reviewed
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here comes the Grid component! This component allows you to arrange static components as a table, where each cell can contain either text or a component reference. The number of rows and columns are fixed, according to what is configured in the layout, so this is not an alternative to repeating groups (where the number of rows are affected by user actions). In contrast to repeating groups, each row here can contain wildly different components (and rows can be styled as
headerrows orreadOnlyrows).More information, and configuration details for this component can soon be found in the documentation.
Important: This feature brings with it many changes to the
frontend-testapp, so until this PR is merged, many of our Cypress tests will be failing when testing on tt02. Sorry for blocking other PRs with this noise!Related Issue(s)
Verification/QA
src/layout/layout.d.tsandlayout.schema.v1.json, and these are all backwards-compatiblekind/*label to this PR for proper release notes grouping