Code

Grid component#1118

Code

Merged

olemartinorg merged 83 commits intomainAltinn/app-frontend-react:mainfrom feat/gridAltinn/app-frontend-react:feat/gridCopy head branch name to clipboardApr 26, 2023

+936-88

Commits

Commits on Feb 27, 2023

• Adding types and basic component infrastructure fro Grid

  

  Ole Martin Handeland

  committed
  8d9d926

  Copy full SHA for 8d9d926

• Fixing type issues in other code now that multiple components have 'rows' in them

  

  Ole Martin Handeland

  committed
  7bcfda1

  Copy full SHA for 7bcfda1

• Basic (possibly even working) support for Grid layout in hierarchy

  

  Ole Martin Handeland

  committed
  70f74ed

  Copy full SHA for 70f74ed

Commits on Feb 28, 2023

• Merge branch 'main' into feat/grid

  

  Ole Martin Handeland

  committed
  778a56d

  Copy full SHA for 778a56d

• Removing expression support temporarily. After the major type changes, this should be ExprVal.String, but that won't work great with the expression defaults, the way they are defined right now (t…

  Show description for c48306c
  

  Ole Martin Handeland

  committed
  c48306c

  Copy full SHA for c48306c

• Fixing other cypress tests so they work after frontend-test changes to support Grid

  

  Ole Martin Handeland

  committed
  17f0c3d

  Copy full SHA for 17f0c3d

• Fixing other cypress tests so they work after frontend-test changes to support Grid

  

  Ole Martin Handeland

  committed
  5a3820d

  Copy full SHA for 5a3820d

Commits on Mar 13, 2023

• Merge branch 'main' into feat/grid

  Show description for 11a946b
  

  Ole Martin Handeland

  committed
  11a946b

  Copy full SHA for 11a946b

• Fixes after merge fom main

  

  Ole Martin Handeland

  committed
  90d0c98

  Copy full SHA for 90d0c98

Commits on Mar 15, 2023

• Early working prototype

  

  Ole Martin Handeland

  committed
  bc5dad1

  Copy full SHA for bc5dad1

• Streamlining code to avoid rendering an empty cell in two different ways. Fixing the readOnly color, as it didn't match the input field.

  

  Ole Martin Handeland

  committed
  70e58c8

  Copy full SHA for 70e58c8

• Merge branch 'main' into feat/grid

  Show description for b3eb626
  

  Ole Martin Handeland

  committed
  b3eb626

  Copy full SHA for b3eb626

• Oooh, apparently we _can_ use the design system here (Webstorm just can't resolve it), and somebody _did_ rewrite the FullWidthWrapper to css modules! Hooray!

  

  Ole Martin Handeland

  committed
  499ddec

  Copy full SHA for 499ddec

Commits on Mar 16, 2023

• Converting getComponent() to a statically defined def

  

  Ole Martin Handeland

  committed
  25ea79a

  Copy full SHA for 25ea79a

• Adding some utility functions for checking the type of component inside a node. The returned result will narrow the type of this.

  

  Ole Martin Handeland

  committed
  f298cdd

  Copy full SHA for f298cdd

• Moving LayoutNode, LayoutPage, LayoutPages and LayoutObject classes into separate files

  

  Ole Martin Handeland

  committed
  5019103

  Copy full SHA for 5019103

• Simplifying the way ExprContext generates its resolved nodes (re-using existing function that does this).

  

  Ole Martin Handeland

  committed
  dc54c67

  Copy full SHA for dc54c67

• Making ExprContext more efficient again, avoiding re-running expressions upon every tiny little state change

  

  Ole Martin Handeland

  committed
  4280454

  Copy full SHA for 4280454

Commits on Mar 21, 2023

• Woah, I kinda started off with a big undertaking, and after a lot of trial and error, I got it working fairly well. Rewriting the layout hierarchy generator to a more modularized one. With this cha…

  Show description for ac04ff8
  

  Ole Martin Handeland

  committed
  ac04ff8

  Copy full SHA for ac04ff8

• Merge branch 'main' into chore/niceties-in-layoutnode

  

  Ole Martin Handeland

  committed
  aa7db64

  Copy full SHA for aa7db64

Commits on Mar 24, 2023

• Merge branch 'main' into feat/grid

  Show description for 49bd10f
  

  Ole Martin Handeland

  committed
  49bd10f

  Copy full SHA for 49bd10f

• Re-implementing overrides in checkboxes/radios after merge from main

  

  Ole Martin Handeland

  committed
  4e096f6

  Copy full SHA for 4e096f6

Commits on Mar 27, 2023

• Fixing my previous commit. This is normally undefined, which is not the same as false.

  

  Ole Martin Handeland

  committed
  2410baa

  Copy full SHA for 2410baa

Commits on Apr 3, 2023

• Merge branch 'main' into chore/niceties-in-layoutnode

  Show description for 83940ec
  

  Ole Martin Handeland

  committed
  83940ec

  Copy full SHA for 83940ec

• Merge branch 'main' into feat/grid

  Show description for b62d768
  

  Ole Martin Handeland

  committed
  b62d768

  Copy full SHA for b62d768

• Cleanup after merge from main

  

  Ole Martin Handeland

  committed
  53e86b1

  Copy full SHA for 53e86b1

• Limiting claims to only one parent

  

  Ole Martin Handeland

  committed
  9a431e4

  Copy full SHA for 9a431e4

• Moving the IGroupPanel type, as it more clearly belongs to the Group component than the Panel component

  

  Ole Martin Handeland

  committed
  737c386

  Copy full SHA for 737c386

• Moving the different stage functions into a common class that can be implemented. One instance is always re-used for every component type, so that we can store state inside it to make group panel r…

  Show description for c6782e9
  

  Ole Martin Handeland

  committed
  c6782e9

  Copy full SHA for c6782e9

Commits on Apr 4, 2023

• Re-implementing panel group references

  

  Ole Martin Handeland

  committed
  bb17a66

  Copy full SHA for bb17a66

• Inching closer to making the hierarchy generator work across multiple layouts

  

  Ole Martin Handeland

  committed
  92e3a9a

  Copy full SHA for 92e3a9a

Commits on Apr 5, 2023

• Adding unit-test for what's left (and failing) in processing panels with group reference

  

  Ole Martin Handeland

  committed
  5b25a7c

  Copy full SHA for 5b25a7c

Commits on Apr 11, 2023

• Adding a stage 3 callback to make some of the unit-tests for group reference on the same page pass

  

  Ole Martin Handeland

  committed
  8a64779

  Copy full SHA for 8a64779

• Making sure stages run to completion before starting processing the next page, thus fixing the group reference problem across pages

  

  Ole Martin Handeland

  committed
  e28e4a3

  Copy full SHA for e28e4a3

• Merge branch 'main' into chore/niceties-in-layoutnode

  

  Ole Martin Handeland

  committed
  4999314

  Copy full SHA for 4999314

• Introducing function as parameter to avoid circular import problem that caused the class extends clause to extend undefined

  

  Ole Martin Handeland

  committed
  51eeb94

  Copy full SHA for 51eeb94

• Fixing unit-tests that were failing because of bad configuration

  

  Ole Martin Handeland

  committed
  d7ccbf0

  Copy full SHA for d7ccbf0

• GenericComponent will never get an unknown component type after this, as those will be filtered away when generating the hierarchy. Fixing the test for this.

  

  Ole Martin Handeland

  committed
  39f1578

  Copy full SHA for 39f1578

• Real apps sometimes create list of children where not all of them exists. Fixing the error so that it's only a warning (i.e. not crashing the app) when children are not found.

  

  Ole Martin Handeland

  committed
  4279ad0

  Copy full SHA for 4279ad0

• Fixing the component type in shared tests - I mistakenly used the wrong type, and that failed hard now

  

  Ole Martin Handeland

  committed
  c8e8c29

  Copy full SHA for c8e8c29

• Preventing infinite recursion in tests now that node references are included

  

  Ole Martin Handeland

  committed
  bf028d9

  Copy full SHA for bf028d9

• Fixing the definition of what a repeating group is. This was off by one.

  

  Ole Martin Handeland

  committed
  c83bcba

  Copy full SHA for c83bcba

• Minor cleanup

  

  Ole Martin Handeland

  committed
  8942cd5

  Copy full SHA for 8942cd5

Commits on Apr 12, 2023

• Adding code to test all existing apps, and fixing some problems I found now that I introduced repeating groups here as well.

  

  Ole Martin Handeland

  committed
  5738047

  Copy full SHA for 5738047

• Fixing mapping rewrites, which failed because I failed to account for the depth marker starting at 1

  

  Ole Martin Handeland

  committed
  cb6b954

  Copy full SHA for cb6b954

• Merge branch 'main' into feat/grid

  Show description for 7ddce53
  

  Ole Martin Handeland

  committed
  7ddce53

  Copy full SHA for 7ddce53

• Adding layout schema for Grid component

  

  Ole Martin Handeland

  committed
  771aa91

  Copy full SHA for 771aa91

• Only allowing header/readOnly props for rows, not individual cells

  

  Ole Martin Handeland

  committed
  f2da040

  Copy full SHA for f2da040

Commits on Apr 13, 2023

• Merge branch 'chore/niceties-in-layoutnode' into feat/grid

  Show description for def9836
  

  Ole Martin Handeland

  committed
  def9836

  Copy full SHA for def9836

• Re-implementing the hierarchy generator for Grid

  

  Ole Martin Handeland

  committed
  f7b7380

  Copy full SHA for f7b7380

• Disallowing some components from being rendered in the table/grid

  

  Ole Martin Handeland

  committed
  6e19664

  Copy full SHA for 6e19664

• Merge branch 'main' into feat/grid

  Show description for 6c18e6b
  

  Ole Martin Handeland

  committed
  6c18e6b

  Copy full SHA for 6c18e6b

• Hising all components on a row also hides the row

  

  Ole Martin Handeland

  committed
  166d1a6

  Copy full SHA for 166d1a6

• Setting !important to override table padding from the design system

  

  Ole Martin Handeland

  committed
  22ff35d

  Copy full SHA for 22ff35d

• Adding label overrides (for a future version of the design system, I had to make some adjustments)

  

  Ole Martin Handeland

  committed
  ce81ef2

  Copy full SHA for ce81ef2

Commits on Apr 14, 2023

• Fixing labels for other components when rendering in table

  

  Ole Martin Handeland

  committed
  a2b8541

  Copy full SHA for a2b8541

• Adding support for text resources

  

  Ole Martin Handeland

  committed
  8784de9

  Copy full SHA for 8784de9

• Adding some test data to use when filling out grid

  

  Ole Martin Handeland

  committed
  c9a63e9

  Copy full SHA for c9a63e9

• Fixing issues when skipping ahead - we have to wait for GridData to load in properly before we inject our data and continue

  

  Ole Martin Handeland

  committed
  7121117

  Copy full SHA for 7121117

Commits on Apr 17, 2023

• add column options for grid

  Magnusrm

  committed
  bc0d492

  Copy full SHA for bc0d492

• more specific css selector in order to override default padding

  Magnusrm

  committed
  fce0bce

  Copy full SHA for fce0bce

• Fixing some cypress tests that are failing. Creating a function to find the navigation button for a named page - everything looks nicer when not selecting the 'nth' page every time.

  

  Ole Martin Handeland

  committed
  80cecbc

  Copy full SHA for 80cecbc

• Adding a simple test for the Grid component

  

  Ole Martin Handeland

  committed
  958d495

  Copy full SHA for 958d495

• widths should sum up to 100%

  Magnusrm

  committed
  9cf4bc5

  Copy full SHA for 9cf4bc5

• Extracting hidden row functionality to a function

  

  Ole Martin Handeland

  committed
  096d2c2

  Copy full SHA for 096d2c2

• Implementing a super-simple mobile grid (just deconstructing into regular components (but hiding header and readOnly rows)

  

  Ole Martin Handeland

  committed
  1942fa1

  Copy full SHA for 1942fa1

Commits on Apr 18, 2023

• Implementing a simple way to render grid components in a Summary

  

  Ole Martin Handeland

  committed
  dca82df

  Copy full SHA for dca82df

• Fixing the navigation so that clicking to edit summary navigates to the actual target component, not the original grid reference

  

  Ole Martin Handeland

  committed
  47a83d4

  Copy full SHA for 47a83d4

• Fixing summaries for checkboxes when no value has been selected. This was missing the 'empty summary' implementation.

  

  Ole Martin Handeland

  committed
  45660df

  Copy full SHA for 45660df

• Adding tests for summary and mobile mode

  

  Ole Martin Handeland

  committed
  d7075cf

  Copy full SHA for d7075cf

• Merge remote-tracking branch 'origin/feat/grid' into feat/grid

  

  Ole Martin Handeland

  committed
  ebf70df

  Copy full SHA for ebf70df

• Merge branch 'main' into feat/grid

  

  Ole Martin Handeland

  committed
  072b7ec

  Copy full SHA for 072b7ec

• Cleaning up tests I changed earlier in the branch history

  

  Ole Martin Handeland

  committed
  ff904a0

  Copy full SHA for ff904a0

• Fixing the navigation routine again, after I broke it by navigating to the first page to fill out the form without going to the last page again before the sendIn button is clicked.

  

  Ole Martin Handeland

  committed
  a03d667

  Copy full SHA for a03d667

• Making .navPage() work on mobile as well

  

  Ole Martin Handeland

  committed
  6077ec8

  Copy full SHA for 6077ec8

• Extracting out methods and simplifying implementation of mobile grid. This also unhides the components in headers and readOnly rows, making the mobile navigation.ts test work properly.

  

  Ole Martin Handeland

  committed
  aded0b8

  Copy full SHA for aded0b8

• The mobile.ts cypress test failed after this change, because the likert radio group now was affected when in mobile mode. Restricting the change to only come into effect when rendered in a table/grid.

  

  Ole Martin Handeland

  committed
  a48c288

  Copy full SHA for a48c288

Commits on Apr 19, 2023

• Merge branch 'main' into feat/grid

  

  Ole Martin Handeland

  committed
  3e10949

  Copy full SHA for 3e10949

Commits on Apr 20, 2023

• Fixing problem with cells, where a later cell could overwrite the header cell (and all other cells) because of object re-use.

  

  Ole Martin Handeland

  committed
  a9f3ebb

  Copy full SHA for a9f3ebb

Commits on Apr 25, 2023

• Merge branch 'main' into feat/grid

  Show description for 6e27455
  

  Ole Martin Handeland

  committed
  6e27455

  Copy full SHA for 6e27455

• Fixing aria-label property after merge from main

  

  Ole Martin Handeland

  committed
  4201f30

  Copy full SHA for 4201f30

• Fixing failing unit test

  

  Ole Martin Handeland

  committed
  0b72fa8

  Copy full SHA for 0b72fa8

Commits on Apr 26, 2023

• Removing console.log

  

  Ole Martin Handeland

  committed
  e0df1c4

  Copy full SHA for e0df1c4