-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom required validation text #1272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works with the missingFieldsInLayoutValidations()
function, and neither the validateEmptyFieldsListComponent()
function. Also, I would assume it conflicts with #1281, so coordinate that with @bjosttveit.
Yes, almost any changes to |
@bjosttveit I'll hold off on this PR until your validation refactor is completed then, and solve the merge conflict then 👍 |
Kudos, SonarCloud Quality Gate passed! |
Closed due to weird merge conflict resolution. New PR: #1333 |
Adding a new customisable validation text for
required
validationsAdded a new property,
requiredValidation
, totextResourceBindings
, which changes the displayed validation text to be the value of properties specified text resource. If this new text resource binding is used, the old default required message is not used.Related Issue(s)
Verification/QA
src/layout/layout.d.ts
andlayout.schema.v1.json
, and these are all backwards-compatiblekind/*
label to this PR for proper release notes grouping