Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom required validation text #1272

Closed
wants to merge 5 commits into from

Conversation

Magnusrm
Copy link
Contributor

@Magnusrm Magnusrm commented Jun 21, 2023

Adding a new customisable validation text for required validations

Added a new property, requiredValidation, to textResourceBindings, which changes the displayed validation text to be the value of properties specified text resource. If this new text resource binding is used, the old default required message is not used.

Related Issue(s)

  • closes

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@Magnusrm Magnusrm changed the title Add custom required validation text and update tests Add custom required validation text Jun 26, 2023
@Magnusrm Magnusrm added the kind/product-feature Pull requests containing new features label Jun 26, 2023
@Magnusrm Magnusrm marked this pull request as ready for review June 26, 2023 13:52
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works with the missingFieldsInLayoutValidations() function, and neither the validateEmptyFieldsListComponent() function. Also, I would assume it conflicts with #1281, so coordinate that with @bjosttveit.

@bjosttveit
Copy link
Member

Yes, almost any changes to validation.ts at this point will conflict with #1281, as most of the functions and related tests are deleted. Should be straightforward to implement afterwards though.

@Magnusrm
Copy link
Contributor Author

@bjosttveit I'll hold off on this PR until your validation refactor is completed then, and solve the merge conflict then 👍

@Magnusrm Magnusrm marked this pull request as draft July 5, 2023 14:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Magnusrm Magnusrm closed this Jul 17, 2023
@Magnusrm Magnusrm deleted the feat/custom-validation-text-required branch July 17, 2023 14:17
@Magnusrm
Copy link
Contributor Author

Closed due to weird merge conflict resolution. New PR: #1333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants