Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom required validation text #1333

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

Magnusrm
Copy link
Contributor

@Magnusrm Magnusrm commented Jul 17, 2023

Description

Added a new property, requiredValidation, to textResourceBindings, which changes the displayed validation text to be the value of properties specified text resource. If this new text resource binding is used, the old default required message is not used.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@Magnusrm Magnusrm mentioned this pull request Jul 17, 2023
21 tasks
@Magnusrm Magnusrm added the kind/feature-request New feature or request label Aug 21, 2023
@Magnusrm Magnusrm marked this pull request as ready for review August 21, 2023 09:24
@Magnusrm Magnusrm marked this pull request as draft August 21, 2023 13:47
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.1% 26.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Magnusrm Magnusrm marked this pull request as ready for review August 22, 2023 09:13
@Magnusrm Magnusrm merged commit 19a9aae into main Aug 28, 2023
@Magnusrm Magnusrm deleted the feat/custom-required-validation-text branch August 28, 2023 08:53
@olemartinorg olemartinorg added kind/product-feature Pull requests containing new features and removed kind/feature-request New feature or request labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible validation text for standard required field
3 participants